Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup before backup #253

Open
wicast opened this issue Aug 19, 2023 · 2 comments
Open

cleanup before backup #253

wicast opened this issue Aug 19, 2023 · 2 comments
Labels
bug Something isn't working

Comments

@wicast
Copy link

wicast commented Aug 19, 2023

Ludusavi version

v0.20.0

Operating system

Windows

Installation method

Scoop

Description

I've used ludusavi with rpcs3 demon souls, but the backup broke my save. Luckly i have a manual backup aside.
The problem was rpcs3 will delete and create some files after saving.
The backup doesn't apply those deletion.
图片

If I do a deletion by hand, the save works fine.

Logs

No response

@wicast wicast added the bug Something isn't working label Aug 19, 2023
@wicast wicast changed the title clean up before backup cleanup before backup Aug 19, 2023
@mtkennerly
Copy link
Owner

mtkennerly commented Aug 19, 2023

Is this a problem with the backup itself, or when you try to restore the backup?

Just to make sure I understand:

  • When you make the first save, the game generates 01USER.DAT
  • When you save again, the game deletes 01USER.DAT and generates 02USER.DAT

And so if you restore a backup of 01USER.DAT, Ludusavi also leaves 02USER.DAT in place, but really it would need to delete 02USER.DAT?

It might make sense to add an option where, before restoring a backup, Ludusavi would scan for any existing save/config files for the game and delete them first. But that could lead to data loss if you had deselected some save files from the backup/restore, since it wouldn't be restoring a full set anymore. I'm not sure the best way to handle this.

@wicast
Copy link
Author

wicast commented Aug 19, 2023

Is this a problem with the backup itself, or when you try to restore the backup?

Just to make sure I understand:

* When you make the first save, the game generates 01USER.DAT

* When you save again, the game deletes 01USER.DAT and generates 02USER.DAT

And so if you restore a backup of 01USER.DAT, Ludusavi also leaves 02USER.DAT in place, but really it would need to delete 02USER.DAT?

yes, that's right.

It might make sense to add an option where, before restoring a backup, Ludusavi would scan for any existing save/config files for the game and delete them first. But that could lead to data loss if you had deselected some save files from the backup/restore, since it wouldn't be restoring a full set anymore. I'm not sure the best way to handle this.

Could it possible to uncheck the file but still tracking it? Which means the checking only controls what will be wrote.
Anyway, add an option as a workround would really help me a lot. I think demon souls is really a corner case(not sure about other games), most of the game save won't do a deletion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants