Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TAFR dungeons have a normal layout #886

Open
kodawah opened this issue Dec 14, 2021 · 2 comments
Open

TAFR dungeons have a normal layout #886

kodawah opened this issue Dec 14, 2021 · 2 comments
Labels
More Information Needed Further information is requested v5.2.X Will be addressed in MTGJSON v5.2.X

Comments

@kodawah
Copy link
Contributor

kodawah commented Dec 14, 2021

all the tokens have a layout set to token but this series doesn't
there needs to be a uniquivocal way to determine whether a card is a token without looking at the parent set

@ZeldaZach
Copy link
Member

If an entity is found within the "tokens" array of a set object, they are 100% a token. The layout doesn't necessarily determine the type. This is the same as all entities found within the "cards" array of a set object are 100% a card in the set, and not a token.

If this isn't clear, we can discuss it further, but I'm not inclined to change anything as of this point.

@ZeldaZach ZeldaZach added the More Information Needed Further information is requested label Dec 17, 2021
@kodawah
Copy link
Contributor Author

kodawah commented Dec 17, 2021

how does the entity know it's found within a token array? There might be a set->token relationship but not a object->token one. It's the same rationale why it's important for a cardObject to have their own setCode

@ZeldaZach ZeldaZach added the v5.2.X Will be addressed in MTGJSON v5.2.X label Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
More Information Needed Further information is requested v5.2.X Will be addressed in MTGJSON v5.2.X
Projects
None yet
Development

No branches or pull requests

2 participants