Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Identify Tourney Promos #770

Open
Lockheed-Dragon opened this issue Feb 19, 2021 · 2 comments
Open

Identify Tourney Promos #770

Lockheed-Dragon opened this issue Feb 19, 2021 · 2 comments
Labels
More Information Needed Further information is requested

Comments

@Lockheed-Dragon
Copy link

Currently all "tourney" promos have the tag promoType == "tourney", this doesn't help identify the type of promo, for example, Mutavault has both a Grand Prix and a Champs promo, both are tagged in an identical fashion. If we are searching without the exact set code, this can cause some confusion.

Can we add identifiers like "tourney,grandprix" or "tourney,champs" similar to the way FNM promos are handled?

Thanks,
Lockheed

@ZeldaZach
Copy link
Member

Hey Lockheed! Looking further at this, can you not just use the set name to determine the type?

@ZeldaZach ZeldaZach added the More Information Needed Further information is requested label Apr 18, 2021
@Lockheed-Dragon
Copy link
Author

Hey Zach, you'll notice in the initial comment, that we may be searching without the exact set code.
Though I can examine the set code of each card returned in my search and extrapolate from there, that's adding complexity that doesn't exist for other similar situations as noted above for FNM promos.

Consistency is king! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
More Information Needed Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants