Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords array needs a rework #757

Open
KingSupernova31 opened this issue Jan 19, 2021 · 3 comments
Open

Keywords array needs a rework #757

KingSupernova31 opened this issue Jan 19, 2021 · 3 comments
Labels
Upstream Issue This is an issue caused by one of our sources

Comments

@KingSupernova31
Copy link

KingSupernova31 commented Jan 19, 2021

  • Black Knight has "Protection", but not "Protection from White"
  • Knight of Malice has both "Hexproof" and "Hexproof from", but not "Hexproof from white"
  • Absorb Vis has both "Basic landcycling" and "Landcycling" while having neither "Typecycling" nor "Cycling"
  • Commander's Plate just has "Equip", not "Equip commander"
  • Deathmist Raptor has "Megamorph" but not "Morph"
@ZeldaZach
Copy link
Member

Thanks for catching these, will make a motion to fix these ones reported.

If you have a full list of broken/incomplete ones, and a list of corrections, that would be even better!

@ZeldaZach ZeldaZach added the Upstream Issue This is an issue caused by one of our sources label Feb 18, 2021
@KingSupernova31
Copy link
Author

KingSupernova31 commented Feb 27, 2021

There are probably hundreds of errors like these; whatever the parsing logic is doing seems to break on most keywords that have arguments or variables. I just picked a few of the clearest examples to showcase the issue, but they're not isolated problems.

@ZeldaZach ZeldaZach changed the title Keywords inconsistently take into account arguments and variants Keywords array needs a rework Jun 10, 2023
@KingSupernova31
Copy link
Author

Another example: Benthic Behemoth has both "Islandwalk" and "Landwalk", while Anaconda has only "Swampwalk", no "Landwalk".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Upstream Issue This is an issue caused by one of our sources
Projects
None yet
Development

No branches or pull requests

2 participants