Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alltcgskus] alt art of some non-English cards shadow the main id #730

Open
kodawah opened this issue Dec 12, 2020 · 1 comment
Open

[alltcgskus] alt art of some non-English cards shadow the main id #730

kodawah opened this issue Dec 12, 2020 · 1 comment
Labels
Data Issue Something isn't correct MTGJSON v5 Issue affects MTGJSON 5 v5.2.X Will be addressed in MTGJSON v5.2.X

Comments

@kodawah
Copy link
Contributor

kodawah commented Dec 12, 2020

there are a few Simplified Chinese-alt art cards that got assigned the same tcgProductid of their English counterpart

https://scryfall.com/card/por/71s/zhs/taunt is an example

this led to a problem in the alltcgskus file: it seems like the id of the main edition got overwritten, and that the english data was assigned to the alt art card - in fact 6581eebc-bbf2-5d44-b325-d97e371bb59f in the file has both ENGLISH and SIMPLIFIED CHINESE language data, while it should only contain SIMPLIFIED CHINESE, and the main card 04333668-23fb-59d8-b682-45e02fb63114 is missing entirely

while it is probably an upstream bug that the alt art share the same tcg id, it would be nice to add some form of validation that checks when there is a data loss like that, and can prioritize the English printing over the other versions

@ZeldaZach
Copy link
Member

I need to look into this further, at some point.

@ZeldaZach ZeldaZach added Data Issue Something isn't correct MTGJSON v5 Issue affects MTGJSON 5 labels Feb 18, 2021
@ZeldaZach ZeldaZach added the v5.2.X Will be addressed in MTGJSON v5.2.X label Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data Issue Something isn't correct MTGJSON v5 Issue affects MTGJSON 5 v5.2.X Will be addressed in MTGJSON v5.2.X
Projects
None yet
Development

No branches or pull requests

2 participants