Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved sealed product categories #1139

Open
axxroytovu opened this issue Oct 12, 2023 · 8 comments
Open

Improved sealed product categories #1139

axxroytovu opened this issue Oct 12, 2023 · 8 comments
Labels
Enhancement New feature or request

Comments

@axxroytovu
Copy link
Contributor

axxroytovu commented Oct 12, 2023 •
edited

The current sealed product categories & subtypes are not consistent and have lots of gaps. My suggestion:

  • Booster
    • Draft
    • Set
    • Collector
    • Promotional
    • Theme
    • Jumpstart
    • Welcome
    • Box Topper
    • Six-card
    • VIP
    • Advanced
  • Booster Box
    • same as Booster
  • Booster Box Case
    • Same as Booster
  • Deck
    • Planeswalker
    • Challenge (different than challenger)
    • Challenger
    • Event
    • Championship
    • Intro
    • Commander
    • Theme
    • Brawl
    • Archenemy
    • Planechase
  • Multiple Decks
    • 2 player starter
    • Duel
    • Clash
    • Booster Battle
    • Game Night
  • Deck Display
    • Same as above
  • Box Set
    • From the Vault
    • Spellbook
    • Secret Lair
    • Secret Lair Bundle
    • Commander Collection
    • Collector's Edition
    • Other
  • Kit
    • Guild Kit
    • Deck Builder's Toolkit
    • Land Station
  • Bundle
    • Default
    • Gift
    • Fat Pack
  • Bundle Case
  • Limited Play Aid
    • Prerelease Pack
    • Draft Play Pack
    • Sealed Play Pack
    • Starter Deck
    • Tournament Deck
  • Limited Play Aid Case
  • Subset (Set of X type products)
  • Other
    • Default
    • Other
    • Premium
@axxroytovu axxroytovu mentioned this issue Oct 12, 2023
Closed
@kodawah
Copy link
Contributor

kodawah commented Oct 12, 2023

The current sealed product categories & subtypes are not consistent and have lots of gaps. My suggestion:

* Booster
  * Draft
  * Set
  * Collector
  * Promotion
  * Theme
  * Jumpstart
  * Welcome

What's the Promotion tag for? Do we need promo pack, and sample and box topper too?

* Booster Box
  
  * same as Booster

* Booster Box Case
  
  * Same as Booster

* Deck
  
  * Commander
  * Challenger
  * Planeswalker
  * Theme
  * Intro
  * Brawl
  * Archenemy
  * Event
  * Pro Tour
  * Planechase

are "pro tour" the gold-bordered World Championship deck? if so i'd rather have the latter name

* Multiple Decks
  
  * Duel
  * Clash
  * Booster Battle
  * 2 player starter
  * Game Night

how about starter kit too?

* Deck Display
  
  * Same as above

* Collectable Set
  
  * Secret Lair
  * Secret Lair Bundle
  * Commander Collection
  * From the Vault
  * Box Set
  * Collector's Edition

Everything is collectable :) shold we just keep box set?

* Kit
  
  * Guild Kit
  * Deck Builder's Toolkit
  * Land Station

arena starter kit? or is it better in multiplayer?

* Bundle
  
  * Gift
  * Fat Pack
  * Draft Pack

bundle draft pack?

* Bundle Case

* Prerelease Pack

* Prerelease Pack Case

* Other
  
  * Default
  * Other
  * Premium

"other default" and "other other" don't convey much information, how about Misc for category and then it's a custom field every time?

@axxroytovu
Copy link
Contributor Author

What's the Promotion tag for? Do we need promo pack, and sample and box topper too?

Promotion was supposed to get collector sample packs, bundle promos, and prize packs. I'll add box topper.

"other default" and "other other" don't convey much information, how about Misc for category and then it's a custom field every time?

The "Other" tags are supposed to be used in conjunction with the other categories, so the Aftermath "Epilogue" packs would be "Booster Pack/Other" or the All will be One Compleat bundle would be "Bundle/Premium"

bundle draft pack?

I didn't know where else to put the "3x draft booster drafting pack"

arena starter kit? or is it better in multiplayer?
how about starter kit too?

Arena starter kits are "Multiple Deck/2 player starter". I think all of the starter kits are designed for 2 players.

are "pro tour" the gold-bordered World Championship deck? if so i'd rather have the latter name

There are some products that are explicitly "Pro Tour" but yes most of them are the WC decks.

Everything is collectable :) shold we just keep box set?

Box set is fine, I just wanted to give it a more descriptive name but it doesn't matter that much.

@kodawah
Copy link
Contributor

kodawah commented Oct 12, 2023

What's the Promotion tag for? Do we need promo pack, and sample and box topper too?

Promotion was supposed to get collector sample packs, bundle promos, and prize packs. I'll add box topper.

so prize packs are the premium and non premium "promo pack"
aka https://mtg.fandom.com/wiki/Universal_promo_pack

"other default" and "other other" don't convey much information, how about Misc for category and then it's a custom field every time?

The "Other" tags are supposed to be used in conjunction with the other categories, so the Aftermath "Epilogue" packs would be "Booster Pack/Other" or the All will be One Compleat bundle would be "Bundle/Premium"

hmm ok

bundle draft pack?

I didn't know where else to put the "3x draft booster drafting pack"

bundle really conveys "the product containing the spindown dice and other stuff" which the 3x set draft don't carry.. maybe making a separate category would be fine? It could be used for all the "set of X" we randomly see pop up

arena starter kit? or is it better in multiplayer?
how about starter kit too?

Arena starter kits are "Multiple Deck/2 player starter". I think all of the starter kits are designed for 2 players.

ok

are "pro tour" the gold-bordered World Championship deck? if so i'd rather have the latter name

There are some products that are explicitly "Pro Tour" but yes most of them are the WC decks.

right, the pro tour is a handful of decks, while the wcd series is a multi year thing, that's why i was suggesting using the more Wold champ name

Everything is collectable :) shold we just keep box set?

Box set is fine, I just wanted to give it a more descriptive name but it doesn't matter that much.

👍

@kodawah
Copy link
Contributor

kodawah commented Oct 12, 2023

any thought for the "in-between" sets, like the secret lair commander decks?

@axxroytovu
Copy link
Contributor Author

IMO the SLD Commander decks are still just commander decks. They're more expensive and sold through a different venue, but the contents are 1 deck of cards.

@axxroytovu axxroytovu mentioned this issue Oct 13, 2023
Merged
@axxroytovu
Copy link
Contributor Author

Reopening until last changes submitted.

Adding LIMITED and SUBSET as valid categories, and associated subtypes

@axxroytovu axxroytovu reopened this Oct 16, 2023
@axxroytovu axxroytovu mentioned this issue Oct 16, 2023
Merged
@axxroytovu
Copy link
Contributor Author

A few lingering issues/questions before I close this.

  1. After assigning categories, these products still use the subtype OTHER. Is there any desire to create new subtypes for any of these products?
Product Anthologies uses subtype OTHER
Product Beatdown uses subtype OTHER
Product Garfield vs Finkel 2001 Deckmasters Tin uses subtype OTHER
Product Explorers of Ixalan uses subtype OTHER
Product 2017 Magic The Gathering Hascon Collection uses subtype OTHER
Product Judge Promo Pack 2014 Full Art Land Set uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Retail Tin Galadriel of Lothlorien uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Retail Tin Gandalf Friend of the Shire uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Retail Tin The One Ring uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Retail Tins Set of 3 uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Scene Box Aragorn at Helms Deep uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Scene Box Flight of the Witch King uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Scene Box Gandalf in the Pelennor Fields uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Scene Box The Might of Galadriel uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Scene Boxes Set of 4 uses subtype OTHER
Product March of the Machine The Aftermath Epilogue Booster Box uses subtype OTHER
Product March of the Machine The Aftermath Epilogue Booster Box Case uses subtype OTHER
Product March of the Machine The Aftermath Epilogue Booster Pack uses subtype OTHER
Product Mirrodin Besieged Faction Booster Box uses subtype OTHER
Product Mirrodin Besieged Mirran Faction Booster Pack uses subtype OTHER
Product Mirrodin Besieged Phyrexian Faction Booster Pack uses subtype OTHER
Product Rivals Quick Start Set uses subtype OTHER
  1. These products use the PREMIUM and VIP categories which seem like they have a lot of overlap. Can these three subtypes be combined for ease of documentation? We already have a DELUXE subtype that is not used for any product and should probably be deleted.
Product War of the Spark Mythic Edition uses subtype PREMIUM
Product Phyrexia All Will Be One Compleat Bundle uses subtype PREMIUM
Product Phyrexia All Will Be One Compleat Bundle Case uses subtype PREMIUM
Product Phyrexia All Will Be One Compleat Edition Booster uses subtype PREMIUM
Product Premium Deck Series Fire and Lightning Deck uses subtype PREMIUM
Product Premium Deck Series Graveborn uses subtype PREMIUM
Product Ravnica Allegiance Mythic Edition uses subtype PREMIUM
Product Throne of Eldraine Deluxe Collection uses subtype PREMIUM
Product Guilds of Ravnica Masterpiece Booster uses subtype PREMIUM
Product Guilds of Ravnica Mythic Edition uses subtype PREMIUM
Product Premium Deck Series Slivers uses subtype PREMIUM
Product Double Masters VIP Edition Booster Box uses subtype VIP
Product Double Masters VIP Edition Booster Box Case uses subtype VIP
Product Double Masters VIP Edition Booster Pack uses subtype VIP
Product Magic 30th Anniversary Edition Booster Box uses subtype PREMIUM
Product Magic 30th Anniversary Edition Booster Pack uses subtype PREMIUM
Product Shards of Alara Premium Foil Booster Box uses subtype PREMIUM
Product Shards of Alara Premium Foil Booster Pack uses subtype PREMIUM

@ZeldaZach ZeldaZach added the Enhancement New feature or request label Nov 28, 2023
@axxroytovu axxroytovu mentioned this issue Dec 13, 2023
Merged
@kodawah
Copy link
Contributor

kodawah commented Apr 10, 2024

  1. my proposal

ANTHOLOGY

Product Anthologies uses subtype OTHER
Product Beatdown uses subtype OTHER
Product Garfield vs Finkel 2001 Deckmasters Tin uses subtype OTHER

GAME

Product Explorers of Ixalan uses subtype OTHER

PROMO

Product 2017 Magic The Gathering Hascon Collection uses subtype OTHER
Product Judge Promo Pack 2014 Full Art Land Set uses subtype OTHER

IMO these are fine as is, they are too few and too generic to categorize consistently

Product The Lord of the Rings Tales of Middle earth Retail Tin Galadriel of Lothlorien uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Retail Tin Gandalf Friend of the Shire uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Retail Tin The One Ring uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Retail Tins Set of 3 uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Scene Box Aragorn at Helms Deep uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Scene Box Flight of the Witch King uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Scene Box Gandalf in the Pelennor Fields uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Scene Box The Might of Galadriel uses subtype OTHER
Product The Lord of the Rings Tales of Middle earth Scene Boxes Set of 4 uses subtype OTHER
Product March of the Machine The Aftermath Epilogue Booster Box uses subtype OTHER
Product March of the Machine The Aftermath Epilogue Booster Box Case uses subtype OTHER
Product March of the Machine The Aftermath Epilogue Booster Pack uses subtype OTHER
Product Mirrodin Besieged Faction Booster Box uses subtype OTHER
Product Mirrodin Besieged Mirran Faction Booster Pack uses subtype OTHER
Product Mirrodin Besieged Phyrexian Faction Booster Pack uses subtype OTHER

STARTER

Product Rivals Quick Start Set uses subtype OTHER

  1. im in favor, there is no reason to keep deluxe, vip, and premium, I don't have a favorite but just one seem enough

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kodawah @ZeldaZach @axxroytovu