Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Does benches/increment.rs increment? #32

Open
cmnord opened this issue Jun 18, 2020 · 2 comments · May be fixed by #33
Open

Does benches/increment.rs increment? #32

cmnord opened this issue Jun 18, 2020 · 2 comments · May be fixed by #33

Comments

@cmnord
Copy link

cmnord commented Jun 18, 2020 •
edited

It looks like increment::unlogged and increment::logged read and writes the same value without incrementing it. Am I misreading the code? Is this the intended behavior?

https://github.com/mtak-/swym/blob/master/benches/increment.rs#L23
@mtak-
Copy link
Owner

mtak- commented Jun 18, 2020

HAH! Yeah. That's an oversight. It shouldn't matter much for the benchmark, but egg on my face for sure.

@cmnord cmnord linked a pull request Jun 20, 2020 that will close this issue
Open
@cmnord
Copy link
Author

cmnord commented Jun 20, 2020

Created #33 to close this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

increment in increment benchmark cmnord/swym
2 participants
@mtak- @cmnord