Skip to content
This repository has been archived by the owner on May 15, 2020. It is now read-only.

Update to Boostrap 3.3 causes ladda-spinner incorrect position. #38

Open
elachlan opened this issue Nov 23, 2014 · 8 comments
Open

Update to Boostrap 3.3 causes ladda-spinner incorrect position. #38

elachlan opened this issue Nov 23, 2014 · 8 comments

Comments

@elachlan
Copy link

I updated to Bootstrap 3.3 using Nuget in visual studio. This caused the spinner to be offset incorrectly.

To fix it I removed the margin-top and margin-left attributes in the CSS for "slide-right".

@msurguy
Copy link
Owner

msurguy commented Nov 25, 2014

Thanks, could you create a pull request on how you fixed it?

@elachlan
Copy link
Author

I really only fixed the slide right style. But I'll put aside some time now and fix them all.

@elachlan
Copy link
Author

.ladda-button .ladda-spinner

In the ladda.css margin-top is -16px, in ladda.scss its 0. Not sure how this is supposed to work.

@elachlan
Copy link
Author

margin-top also has different values for the *.css and *.min.css

This would explain why I was getting the error in MVC, since I used the non-minified stylesheet and had bundling minify it for me.

@elachlan
Copy link
Author

OK. Looks like when you did the update "Cleanup and update Ladda to 0.9.4" you didn't update the non-minified files.

This is the cause of the issue.

@iamtankist
Copy link

Guys, any update on this?

@elachlan
Copy link
Author

I ended up using the minified files instead. Its no ideal though.

@BasKiers
Copy link

Still having this problem with the ladda-themeless.css and it is fixed when I include ladda-themeless.min.css.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants