Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cluster-stamp.json has a default location set -- should it? #297

Open
larryclaman opened this issue Mar 20, 2022 · 1 comment
Open

cluster-stamp.json has a default location set -- should it? #297

larryclaman opened this issue Mar 20, 2022 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@larryclaman
Copy link

per

"defaultValue": "eastus2",

it sets the default location of the deployment to 'eastus2'. Perhaps the default should be removed.

Additionally, the example in the instructions should probably explicitly provide a location as a parameter, see

az deployment group create -g rg-bu0001a0008 -f cluster-stamp.json -p targetVnetResourceId=${RESOURCEID_VNET_CLUSTERSPOKE_AKS_BASELINE} clusterAdminAadGroupObjectId=${AADOBJECTID_GROUP_CLUSTERADMIN_AKS_BASELINE} a0008NamespaceReaderAadGroupObjectId=${AADOBJECTID_GROUP_A0008_READER_AKS_BASELINE} k8sControlPlaneAuthorizationTenantId=${TENANTID_K8SRBAC_AKS_BASELINE} appGatewayListenerCertificate=${APP_GATEWAY_LISTENER_CERTIFICATE_AKS_BASELINE} aksIngressControllerCertificate=${AKS_INGRESS_CONTROLLER_CERTIFICATE_BASE64_AKS_BASELINE} domainName=${DOMAIN_NAME_AKS_BASELINE} gitOpsBootstrappingRepoHttpsUrl=${GITOPS_REPOURL}

@ckittel
Copy link
Member

ckittel commented Mar 21, 2022

Yeah, we left the default in here, but I agree that it should instead be passed in based on the spoke network's region. That way everything flows without needing to make modifications. Make the spoke decision once, and then it informs the rest of the regional decisions. We can put this on our backlog. Likely won't be picked up for a while, but if you happen to implement this before then, PRs welcome. We'll keep this issue open for tracking.

@ckittel ckittel added enhancement New feature or request good first issue Good for newcomers labels Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants