dts: msm8926: add Support for Samsung Galaxy S5 Mini Duos (kmini3g) #279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vicenteicc2008
changed the title
vicenteicc2008
changed the title
TravMurav
reviewed
Jul 30, 2023
| @@ -119,6 +119,7 @@ page on the EFIDroid wiki for an exact mapping of LK targets to SoCs. | |||
| - Motorola Moto G 2013 - falcon | |||
| - Samsung Galaxy Grand 2 - SM-G7102 | |||
| - Samsung Galaxy Tab 4 10.1 (2014) - SM-T530, SM-T535 | |||
| - Samsung Galaxy S5 Mini Duos - SM-G800H | |||
There was a problem hiding this comment.
I believe S goes before T in the alphabet :)
|
buttons working fine |
TravMurav
reviewed
Aug 2, 2023
|
i am having error (MODEL- unknown (FIXME!)) and does not recognize in my computer |
TravMurav
reviewed
Aug 4, 2023
dts/msm8226/rules.mk
Outdated
| @@ -10,4 +10,5 @@ DTBS += \ | |||
| $(LOCAL_DIR)/msm8226-samsung-ms013g.dtb \ | |||
| $(LOCAL_DIR)/msm8926-huawei-g6-l11-vb.dtb \ | |||
| $(LOCAL_DIR)/msm8926-samsung-r02.dtb \ | |||
| $(LOCAL_DIR)/msm8926-v2-720p-mtp.dtb | |||
| $(LOCAL_DIR)/msm8926-v2-720p-mtp.dtb \ | |||
| $(LOCAL_DIR)/msm8926-samsung-r04.dtb | |||
There was a problem hiding this comment.
How about msm8228 instead?
https://desktop.firmware.mobi/device:346
dts/msm8226/msm8926-samsung-r04.dts
Outdated
|
|
||
| / { | ||
| // This is used by the bootloader to find the correct DTB | ||
| qcom,msm-id = <0x6E08FF01 4 0x20000>; |
There was a problem hiding this comment.
Where do you know about 0x6E (110)? It's neither msm8226, 8926, 8228 or 8928
dts/msm8226/msm8228-samsung-r03.dts
Outdated
Comment on lines
10
to
11
| qcom,msm-id = <221 0>; | ||
| qcom,board-id = <0xdf08ff01 3>; |
There was a problem hiding this comment.
I guess older SoC/bootloader doesn't seem to support qcom,board-id
| @@ -10,4 +10,5 @@ DTBS += \ | |||
| $(LOCAL_DIR)/msm8226-samsung-ms013g.dtb \ | |||
| $(LOCAL_DIR)/msm8926-huawei-g6-l11-vb.dtb \ | |||
| $(LOCAL_DIR)/msm8926-samsung-r02.dtb \ | |||
| $(LOCAL_DIR)/msm8926-v2-720p-mtp.dtb | |||
| $(LOCAL_DIR)/msm8926-v2-720p-mtp.dtb \ | |||
| $(LOCAL_DIR)/msm8228-samsung-r03.dtb | |||
There was a problem hiding this comment.
...
$(LOCAL_DIR)/msm8226-*.dtb \
$(LOCAL_DIR)/msm8228-*.dtb \
$(LOCAL_DIR)/msm8926-*.dtb \
...
this removes the home button support from dts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this adds support for Samsung Galaxy S5 Mini Duos (kmini3g)