lk2nd 0.11.0 broke support for htc-m8qlul

[Newbytee]

Some change between lk2nd 0.10.0 and 0.11.0 broke htc-m8qlul. With lk2nd 0.11.0, it boots into HTC's fastboot mode right on boot. I haven't bisected this yet, but I'm making this for tracking purposes.

Edit: A previous version of this post said it boots into EDL mode. I cannot reproduce this any more. It might have been the result of me not doing clean builds. Now, it boots into HTC's fastboot mode instead.

[Newbytee]

I got this:

5f03ceed84a95be6283343c0fbf0ec813557c9b0 is the first bad commit
commit 5f03ceed84a95be6283343c0fbf0ec813557c9b0
Author: Minecrell <minecrell@minecrell.net>
Date:   Thu Oct 28 17:22:40 2021 +0200

    makefile: Drop -fno-builtin
    
    This allows gcc to inline standard calls like strlen("constant string").

 include/stdio.h   | 1 +
 lib/libc/printf.c | 6 ++++++
 makefile          | 2 +-
 3 files changed, 8 insertions(+), 1 deletion(-)

I can also confirm that its parent, 9d9c3ab, kind of works. The phone repeatedly vibrates on the HTC splash, but if I hold down the power and volume down buttons down for a moment it somehow makes it to a functional lk2nd.

However, reverting 5f03cee on top of 0.11.0 does not work. The phone just goes to its own fastboot if I do that, even with the non-m8qlul dtbs removed from the build.

[Newbytee]

Honestly I'm not sure what to make of this. Previously the device went into EDL mode when I built 5f03cee, but now it goes into fastboot mode with that commit.

[stephan-gh]

22:27 <minecrell[m]> "makefile: Drop -fno-builtin" is broken with some gcc versions until 1b36977
22:27 <minecrell[m]> so that may be a false positive