New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odyssey New Ingredients #589
Comments
Howdy all devs for this wonderful app. I am keen to help out here, but not a regular user of GitHub or developer apart from soem basic scripting, not sure I want to step on any toes or add updates to the master - but happy to check specific things or testing to confrim wiki data for final json update and make this Odyssey compatible asap. Let me know if i can be of help in that regard - or anything to help you out here. |
Looked around a little. INARA has made the following categories for odyssey stuff: INARA does not contain FormattedName though. Question: Do we add the "value" where rarity should be or do we need an additional field? I also see that ED Discovery has lists of what seem to be Name and FormattedName. Neither INARA or EDD seem to have complete lists though, so main issue is lack of data right now. EDD might have, but I haven't found it in their code. Also, there does not seem to be any groupings for the new stuff. |
formatted name is used by edengineer to figure out the "code name" that appears in the game logs to be able to pick up cargo updates - some of them are just the label seen by the player but in lowercase while some others have a completely different name a good start is to format the label seen by the player by default - maybe then we'll see issues such as "that ingredient isn't tracked by edengineer" which means we'll need to update the FormattedName
cost / barter / unit should be added as new fields (replacing rarity for these) },
{
// ...
"CostUnit": "Chemicals",
"BarterCost": 9,
"BarterValue": 5,
// ...
},
{
OriginDetails is used for these icons: We can add more origins / icons if new location types have been added although I think "planerary settlement" or something similar already exists |
Thank you. Do we separate OdysseyData and OdysseyItems that do not have barter values into different files with a different setup, or do we just leave barter values blank. |
I checked a bit more the update, I think for these new items, we should have: This will make EDEngineer show all these new ingredients in a new dedicated tab (the Kind - Similarly to Materials/Data/Loadout) and group them by their unit (chemicals / circuits / etc.. similarly to current Alloys / Capacitors / etc...) for reference, current gui: |
I currently have something like this for components: [ All components with values are in my spreadsheet. I have used "OdysseyComponent", "OdysseyData" and "OdysseyItem". Basically I'm using INARA categories. My main challenge is generating the array in there. I'm not a programmer, and the online tools are limited. But if we leave it blank or with just one value, it's fine. |
that looks great you can actually remove the CostUnit field and put it in the Group instead: [
{
"Name": "Aerogel",
"BarterCost": 9,
"BarterValue": 5,
"FormattedName": "aerogel",
"Kind": "OdysseyComponent",
"OriginDetails": [ "Planetary Settlement" ],
"Group": "Chemicals"
}
] |
I'm not comfortable making Pull Requests yet. |
For Items and Data there is no rarity or value information. Do I take value fields out but leave rarity in or take them all out? |
like that is perfect for items & data I believe you could put them as the same Kind as the components but with dedicated group ("Group": "Items" / "Group": "Data") if they don't have rarity in game, you can omit the rarity in the json |
So I have a complete list of data and items based on the sources I have available (INARA, ED Wiki, my journals and EDD) Classification: Data So how much should be included? |
the additional data can be added to the json to maybe be integrated in the gui at some point later if it's too much trouble then it's all right to begin with minimal info : EDEngineer will track the new ingredients and we'll be able to add the related blueprints to report progress thanks a lot 👍 |
I have been playing a bit with the tools I found. { Doing it this way means we can leave out Origin Details, but I thought it might be an idea to keep it, as you have used it for various stuff. I have all the data entered for Chemicals/Circuits/tech Additional data from INARA and the ED Wiki Bonus is: I'm starting to learn how powerful VS Code is :) |
that looks great
edengineer works a bit differently for recipes (file here - beware it's big and can take a while to lead) : blueprints reference the ingredients and not the other way around so for now you can drop this field I think example recipe in blueprints.json file (to avoid loading the file): {
"Type": "Plasma Accelerator",
"Name": "Short Range Blaster",
"Engineers": [
"Etienne Dorn",
"Zacariah Nemo",
"Bill Turner"
],
"Ingredients": [
{
"Name": "Nickel",
"Size": 1
}
],
"Effects": [
{
"Effect": "+27%",
"Property": "Damage",
"IsGood": true
},
{
"Effect": "-10%",
"Property": "Maximum Range",
"IsGood": false
}
],
"Grade": 1,
"CoriolisGuid": "81dca970-1fbf-4017-af46-0c6285c3a728"
}, |
Great Do you want this as one file where I leave in BarterCost and BarterValue in for "Item" and "Data" objects, or as two files? |
I have made a single file for all Odyssey Material. If it needs tweaking or separating into different files, please shout out. |
brilliant - you can append the content of the array to the entryData.json file and open a review i'll start working on exploiting that data soon |
So I made a draft pull request with Odyssey materials #597 |
brilliant, we're soon there in game, have you got some of the new ingredients? would you mind uploading your logs (including the new backpack.json file described in these docs http://hosting.zaonce.net/community/journal/v31/Journal_Manual_v31.pdf) |
I have a few, not many though. |
That was fast. These plus E-breach are all currently known consumables. {
"Consumables":
[ { "Name":"healthpack", "Name_Localised":"Medkit", "OwnerID":0, "Count":10 },
{ "Name":"energycell", "Name_Localised":"Energy Cell", "OwnerID":0, "Count":11 },
{ "Name":"amm_grenade_emp", "Name_Localised":"Shield Disruptor", "OwnerID":0, "Count":10 },
{ "Name":"amm_grenade_frag", "Name_Localised":"Frag Grenade", "OwnerID":0, "Count":10 },
{ "Name":"amm_grenade_shield", "Name_Localised":"Shield Projector", "OwnerID":0, "Count":10 }
{ "Name":"bypass", "Name_Localised":"E-Breach", "OwnerID":0, "Count":96 }
]
}
|
@Gimi1967 ddoes this help? |
So .. I lost ALL my "Goods" and "Data" from all things odyssey. I dont think it was due to mucking around with log files, but be caeful, nearly 1000 goods, 800 odd data- just gone. Ticket with fdev, but that may take weeks. I was stuck, so logged into Horizons, back to Odyssey, those two catagories are reset to 0/1000, whereas "consumables" and the "Assets" are still fine. |
Btw - the e-breech count I guess can be adjusted back to 10 or whatever. thats just the count i had in my bag :P |
I think we have most of it now thanks a lot for the contributions @Gimi1967 and @jpacelli62 upcoming steps:
|
I'm working on events, TradeMicroResources works now for me. |
You guys are awesome .. if need logs or testing anything - shout out. |
New ingredients:
https://elite-dangerous.fandom.com/wiki/Data
https://elite-dangerous.fandom.com/wiki/Components
https://elite-dangerous.fandom.com/wiki/Goods
The ingredient file will need to be updated:
https://github.com/msarilar/EDEngineer/blob/master/EDEngineer/Resources/Data/entryData.json
Example ingredient:
The text was updated successfully, but these errors were encountered: