Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MaterialDiscovered events suppress the corresponding MaterialCollected event #16

Closed
srjek opened this issue Nov 6, 2016 · 6 comments
Closed

Comments

@srjek
Copy link
Contributor

srjek commented Nov 6, 2016

EDEngineer at times can appear to not update when one picks up a material for the first time. As a example, I discovered yttrium, tin, and arsenic in the log at http://pastebin.com/raw/iiZD206i.

The root cause seems to Elite not posting a MaterialCollected event when the material is discovered, but EDEngineer could maybe assume MaterialDiscovered means 3 minerals were added until Elite fixes it on their side. I'm not sure what happens when a material is discovered by a mission, where the reward may not always have a count of 3.

@msarilar
Copy link
Owner

msarilar commented Nov 6, 2016

thanks for the report & investigation.
I indeed assumed two events would be raised upon discovering an element (discovery and collection)... we can work something out though.

You warn about missions not necessarily rewarding 3 materials but are you sure looted materials on a planet always come in triple?

@msarilar msarilar added the bug label Nov 6, 2016
@srjek
Copy link
Contributor Author

srjek commented Nov 6, 2016

Yes. In the current version, whenever you scoop a material or scan data, you always get 3 instead of 1. This was changed in 2.1.05, before journal logs were added. ("When collecting physical micro resources or retrieving data loot, add 3 to the inventory instead of 1. If your inventory can't fit 3, just add enough to fill the inventory" at https://forums.frontier.co.uk/showthread.php/276723-2-1-05-update-incoming)

@srjek
Copy link
Contributor Author

srjek commented Nov 6, 2016

So, unfortunately, MaterialDiscovered events suppress MaterialCollected events even when one finishes a mission. Since the rewards of a mission can vary, and as far as I know no other events indicate the count of the material received, there's nothing that can be done about this until FDev does something.

I completed 2 missions in the logs at http://pastebin.com/raw/cgvMuJ7u, the first is a undiscovered material, the second was an already discovered material.

In other news, I can confirm the latest version is working correctly with scooped/scanned materials.

@msarilar
Copy link
Owner

msarilar commented Nov 6, 2016

thanks a lot for investigating this! you might want to report this directly to Frontier :)

@srjek
Copy link
Contributor Author

srjek commented Nov 6, 2016

Already did at https://forums.frontier.co.uk/showthread.php/305543-MaterialDiscovered-events-have-no-corresponding-MaterialCollected-event

@msarilar msarilar closed this as completed Nov 6, 2016
@msarilar msarilar self-assigned this Nov 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants