Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reset password error #24

Open
Damindu71 opened this issue Dec 4, 2020 · 6 comments
Open

reset password error #24

Damindu71 opened this issue Dec 4, 2020 · 6 comments

Comments

@Damindu71
Copy link

No description provided.

@ARGO1960
Copy link

Not Sure what the problem should be ;-)
But what I found is the password reset url can be used if the password has been reset by that link before.
I think it should be invalidated when used one time.

other issue is the validation link that comes with password reset and very email...
it starts with localhost/logonsystem/ and it should be the actual host.

@msaad1999
Copy link
Owner

I will update the token security, it really is weak if it can be reused like that again.
As for the localhost urls, I will make a host entry in env files to manually set the desired Host. I'll get to these as soon as I get time

@zotz
Copy link

zotz commented Jan 12, 2021

I just did that this morning like this:

At the bottom of env.php:

if (!defined('WEB_ADDRESS')) define('WEB_ADDRESS', 'http://bahamianornuttin.com/'); if (!defined('WEB_DIR')) define('WEB_DIR', 'rivz/test11/');

in register/includes/sendverificationemail.inc.php:
$url = WEB_ADDRESS . WEB_DIR . "verify/includes/verify.inc.php?selector=" . $selector . "&validator=" . bin2hex($token);

in verify/includes/sendverificationemail.inc.php:
$url = WEB_ADDRESS . WEB_DIR . "verify/includes/verify.inc.php?selector=" . $selector . "&validator=" . bin2hex($token);

in reset-password/includes/sendtoken.inc.php:
$url = WEB_ADDRESS . WEB_DIR . "reset-password/?selector=" . $selector . "&validator=" . bin2hex($token);

Not sure this is the best way to go about it but it seems to be working.

all the best,

drew

@msaad1999
Copy link
Owner

@zotz thanks for the quick fix, I may improve on it in the future, but currently, since you are the one who implemented the fix, why not make a pull request to the original repo as your own contribution.
Thanks for the fix. I apologize for the lack of active support I can provide at the moment due to some work, but I really appreciate any effort from you guys.

@zotz
Copy link

zotz commented Jan 15, 2021 via email

@msaad1999
Copy link
Owner

Ah no problem. Just make the required changes to your code, then make a Pull Request from that to this main repository. I'll review the changes and accept it, which will include and show your contributions in the repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants