New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show the password plainly in `addrb -h` #4

Open

doronbehar opened this issue Nov 20, 2022 · 1 comment

doronbehar commented Nov 20, 2022

Although you require this information as an environment variable, it's not considered good practice to print it like that.

Line 47 in 785d726

os.Getenv("CARDDAV_PASSWORD"),

Owner

mrusme commented Nov 20, 2022

What's the different between:

export CARDDAV_PASSWORD='abc123'
addrb -h

and

export CARDDAV_PASSWORD='abc123'
echo $CARDDAV_PASSWORD

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment