Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support in Vcpkg #6016

Open
luodaoyi opened this issue May 28, 2023 · 7 comments
Open

Support in Vcpkg #6016

luodaoyi opened this issue May 28, 2023 · 7 comments

Comments

@luodaoyi
Copy link

Can mruby support in vcpkg?

@rubyFeedback
Copy link

It may help laying down which steps would be necessary for that. What steps would be necessary for mruby to be available via vcpkg as well?

@luodaoyi
Copy link
Author

luodaoyi commented Jun 1, 2023

https://learn.microsoft.com/zh-cn/vcpkg/examples/packaging-github-repo
https://learn.microsoft.com/zh-cn/vcpkg/examples/packaging-zipfiles

like this ?

It may help laying down which steps would be necessary for that. What steps would be necessary for mruby to be available via vcpkg as well?

@matz
Copy link
Member

matz commented Jun 6, 2023

Thank you for the suggestion. Unfortunately, I don't know anything about vpkg. Actually, I have never programmed on Windows. If you (or anyone) send me a pull-request, I'd love to merge.

@luodaoyi
Copy link
Author

It's use cmake ...

@dearblue
Copy link
Contributor

Please note that I have never used vcpkg or written a cmake file, so this is all speculation.

As far as I can see, the vcpkg repository receives a pull request for build instructions for an arbitrary package.
The cmake file would be placed on the vcpkg side.
😿 No ports/ruby, so here's a link to python: https://github.com/microsoft/vcpkg/blob/2023.06.20/ports/python3/portfile.cmake

Also, it seems that cmake has a function to call external commands.
Therefore, it may be possible to use rake DESTDIR=... install from the vcpkg side.

In addition, it seems that vcpkg-specific patches for mruby can also be placed on the vcpkg side.

To sum up:

  • Probably no work needed in the mruby repository.
  • Probably someone interested will send a pull request to vcpkg (probably as ports/mruby).
  • Probably interested parties will update ports/mruby on the vcpkg side with a pull request.

@luodaoyi
Copy link
Author

luodaoyi commented Jun 25, 2023

Please note that I have never used vcpkg or written a cmake file, so this is all speculation.

As far as I can see, the vcpkg repository receives a pull request for build instructions for an arbitrary package. The cmake file would be placed on the vcpkg side. 😿 No ports/ruby, so here's a link to python: https://github.com/microsoft/vcpkg/blob/2023.06.20/ports/python3/portfile.cmake

Also, it seems that cmake has a function to call external commands. Therefore, it may be possible to use rake DESTDIR=... install from the vcpkg side.

In addition, it seems that vcpkg-specific patches for mruby can also be placed on the vcpkg side.

To sum up:

  • Probably no work needed in the mruby repository.
  • Probably someone interested will send a pull request to vcpkg (probably as ports/mruby).
  • Probably interested parties will update ports/mruby on the vcpkg side with a pull request.

Correct! But i am not cmake expert. I am only use it.

@diamant3
Copy link

Hi, I take the initiative on this issue and have already sent a PR to vcpkg, here: microsoft/vcpkg#32847 but please don't have high hopes because i'm neither an expert in cmake nor a mruby user(sorry, but I'll try this on my future projects ❤️)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants