You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is a GroupActivity model to show group based activities. All GroupActivity objects are generated by hard coded lines somewhere in the code. This is bad practice, cause there are many depending codelines.
Enhancement
Take a look on the netbox solution to track changes of models. There is one ChangeLoggedModel as an abstract model, which has all needed logic to store ObjectChange objects on model instance changes. This is a high generic way to track history of a instance of a model. We should implement the same, instead of GroupActivity.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
Status quo
There is a GroupActivity model to show group based activities. All
GroupActivity
objects are generated by hard coded lines somewhere in the code. This is bad practice, cause there are many depending codelines.Enhancement
Take a look on the netbox solution to track changes of models. There is one
ChangeLoggedModel
as an abstract model, which has all needed logic to storeObjectChange
objects on model instance changes. This is a high generic way to track history of a instance of a model. We should implement the same, instead ofGroupActivity
.Beta Was this translation helpful? Give feedback.
All reactions