Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose 'count' property in BatchedMesh #28109

Open
Kikedao opened this issue Apr 10, 2024 · 0 comments
Open

Expose 'count' property in BatchedMesh #28109

Kikedao opened this issue Apr 10, 2024 · 0 comments

Comments

@Kikedao
Copy link

Kikedao commented Apr 10, 2024

Description

BatchedMesh doesn't have a public count property, InstancedMesh does though (https://threejs.org/docs/#api/en/objects/InstancedMesh.count).

Without it it becomes pretty complicated to know how many objects/geometries have been added to a BatchedMesh instance and do operations like traversing all of them to set the matrices, make sure you are in the range before updating one of them, etc.

Solution

I see that the BatchedMesh implementation is already using a private _geometryCount property, it should be as easy as to rename it as count and update the docs.

Alternatives

I think the proposed solution is the best as it would converge the API with InstancedMesh.

Additional context

No response

@Kikedao Kikedao changed the title Expose count in BatchedMesh Expose 'count' property in BatchedMesh Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants