New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WebGLArrayRenderTarget: Constructor texture options are not respected #28100
Comments
This is because of the following line:
Meaning the texture reference is redefined with a new instance. The solution is using the same approach like in |
I'm wondering if it would be nice to have a |
I've noticed something confusing. E.g. the default value of the
|
I wonder if we should just redefine the configuration options of both target = new THREE.WebGLArrayRenderTarget( 1, 1, 1 );
target.texture.wrapS === THREE.RepeatWrapping; instead of target = new THREE.WebGLArrayRenderTarget( 1, 1, 1, { wrapS: THREE.RepeatWrapping } ); |
My preference would be to not break a bunch of usages of WebGLRenderTarget for such a minor superficial change.
If we add something like a this.texture = new DataTexture( null, width, height, depth )
this.texture.setValues( {
minFilter: LinearFilter,
magFilter: LinearFilter,
...options
} ); |
Description
When passing texture options into the
WebGLArrayRenderTarget
constructor they are not retained on thetarget.texture
objects as expected.Reproduction steps
Code
Live example
Run above code in three.js docs console
Screenshots
No response
Version
163
Device
Desktop
Browser
Chrome
OS
MacOS
The text was updated successfully, but these errors were encountered: