New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect ES5 bundle format #17919
Comments
Note that ES2015 === ES6. The The decision to start using ES6 features is discussed in #6419 and #11552. I don't know whether there was a particular reason we aren't transpiling the module entry. We could, and there are pros/cons to that, but it is not required by any specification — could you explain why you need ES5 to be provided directly by three.js itself? |
From your link (my bold added):
This is not a specification, just a note in a help document. By not transpiling I haven't followed the discussion around that decision closely, but this seems to be the idea:
|
Description of the problem
Threejs dist are conain non-transpiled es6 syntax in es5 bundle (which pointed by packajge.json
module
property)ES5 module package format mean that es5 bundle should not contain es6 features excepts import/export (due to support named imports and threeshaking feature).
Could you please improve your rollup config to supports specification:
https://github.com/rollup/rollup/wiki/pkg.module#wait-it-just-means-import-and-export--not-other-future-javascript-features
Example:
class BoxGeometry extends Geometry
in https://raw.githubusercontent.com/mrdoob/three.js/dev/build/three.module.jsThree.js version
Browser
OS
Hardware Requirements (graphics card, VR Device, ...)
The text was updated successfully, but these errors were encountered: