Evaluate code auto-formatting

[enomado]

• Fast typing
• Much simpler diffs
• It gives some freedom on line breaks so matrix, for example, shouldn't be formatted inline. But there is ingoring also exists

[Mugen87]

I'm not sure I understand your issue. What do you expect here from the three.js project?

[donmccurdy]

The project already has an eslint config, so eslint --fix should already work. But I don't know that we would want to require it for every PR, or apply it to the existing codebase wholesale. It's just there for those who find automation makes it easier to follow the styleguide.

[enomado]

I notice #11552 and #15545 and search issue where I can read discussion about using some auto-formatting tools like prettier to do format-on-save in editor.

Looks like I find Mr.doob's Code Style™. Is there any config for this style?

@donmccurdy, does this tool actually fix/add/remove trailing commas, spaces? Like here https://prettier.io/playground/

[gkjohnson]

Is there any config for this style?

The ESLint config for this project is defined in the package.json:

https://github.com/mrdoob/three.js/blob/dev/package.json#L27-L44

does this tool actually fix/add/remove trailing commas, spaces?

Running eslint --fix can auto-fix all those issues. There are also code editor plugins that afford inline linter error highlighting and probably allow for auto-format on save, too (though I don't use that myself).

[donmccurdy]

For example:

// Before
function doTheThing(arg){
	var foo = '2389' + arg;
	console.log(foo);
}
doTheThing('_yeah');

// After `eslint --fix sample.js`
function doTheThing( arg ) {

	var foo = '2389' + arg;
	console.log( foo );

}
doTheThing( '_yeah' );

As @gkjohnson mentions, you can set up your editor to do this automatically, but threejs doesn't require any particular editor.

[enomado]

Even didn't know about this eslint feature.
Current VS Code config looks like:

"editor.formatOnSave": false
"eslint.autoFixOnSave": true

Thanks.