Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typo in CompressedTexture.d.ts #16915

Closed
hjlld opened this issue Jun 26, 2019 · 3 comments · Fixed by #16924
Closed

Typo in CompressedTexture.d.ts #16915

hjlld opened this issue Jun 26, 2019 · 3 comments · Fixed by #16924
Labels
Bug

Comments

@hjlld
Copy link

hjlld commented Jun 26, 2019

three.js/src/textures/CompressedTexture.d.ts

Line 17 in 8aa8b6b

format?: PixelFormat,

format?: PixelFormat, should be format?: CompressedPixelFormat
@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 26, 2019

Would you like to do a PR with the change?

@hjlld
Copy link
Author

hjlld commented Jun 27, 2019

@Mugen87 Sorry, I wish, but I'm a noob to github, not familiar with how to send PR and contribute to big project. :(

@Mugen87 Mugen87 mentioned this issue Jun 27, 2019
Merged
@Mugen87
Copy link
Collaborator

Mugen87 commented Jun 27, 2019 •
edited

No problem. Should be fixed now 👍

Thanks for reporting this issue!

@mrdoob mrdoob added Bug and removed Bug (easy) labels Mar 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

TS: Fix .format type in CompressedTexture. Mugen87/three.js
3 participants
@mrdoob @hjlld @Mugen87