box3.intersectsPlane bug

[shyf1301]

In the following example, the plane obviously intersects with the box, but the function intersectsPlane returns false.
example
I find that adding two negative sign before both of the plane.constant can fix the bug.

three.js/src/math/Box3.js

Line 387 in c570b9b

return ( min <= plane.constant && max >= plane.constant );

Also, I think the definition of the constant of the plane is not distinct, which cause the bug.

Three.js version

• Dev
• r96
• ...

Browser

• All of them

OS

• All of them

[Mugen87]

Good find! Would you like to do a PR with the fix? It would be great if you also adjust the wrong unit test.

Also, I think the definition of the constant of the plane is not distinct, which cause the bug

three.js uses Hessian Normal Form, a common way to specify planes. I think okay to stick with that.

[WestLangley]

@Mugen87 Something is wrong, then. Can you please figure out why your unit test did not catch this. #7445

[Mugen87]

The test was wrong, too. Fixed in #14836