We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#13993 introduced an optimization to Box3#applyMatrix4() that only supports affine transforms.
Box3#applyMatrix4()
CodePen
geometry.applyMatrix()
applyMatrix()
r93 Box3#applyMatrix4()
r92 Box3#applyMatrix4()
Box3
For BoxGeometry, it is expected is that both operations result in equivalent Box3 instances.
BoxGeometry
The r92 version transformed each Box3 vertex, then used setFromPoints() to resize to fit.
r92
setFromPoints()
See #6039 for a similar issue with a Vector3#applyMatrix4() optimization.
Vector3#applyMatrix4()
The text was updated successfully, but these errors were encountered:
@razh Thank you for providing a well-written and clear demo.
I support reverting #13993.
Sorry, something went wrong.
/cc @mikialex
I haven't consider the case that matrix is not affined, for consistency it should be revert
No branches or pull requests
Description of the problem
#13993 introduced an optimization to
Box3#applyMatrix4()
that only supports affine transforms.CodePen
geometry.applyMatrix()
- The geometry is transformed withapplyMatrix()
.r93 Box3#applyMatrix4()
&r92 Box3#applyMatrix4()
- ABox3
instance is constructed from the geometry. A non-affine matrix is then applied.For
BoxGeometry
, it is expected is that both operations result in equivalentBox3
instances.The
r92
version transformed eachBox3
vertex, then usedsetFromPoints()
to resize to fit.See #6039 for a similar issue with a
Vector3#applyMatrix4()
optimization.Three.js version
Browser
OS
The text was updated successfully, but these errors were encountered: