-
-
Notifications
You must be signed in to change notification settings - Fork 35.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NodeMaterial, how to interface with properties #14254
Comments
Let's not start an issue on this please. My example code was purely a speculative attempt at a backward-compatible MeshStandardMaterial implementation on top of nodes, and it is not worth discussing specific syntax here until some code exists to discuss. The goal here is to have a backward-compatible state for existing code, and not that we would encourage people to mix and match nodes and previous syntax in that way. |
@donmccurdy The only insight i can find into interfacing with I find the 2400 overwhelming. A minimal example would be much more valuable. Could you please reopen this if i remove your code reference? I can study the node example and come up with something minimal. |
@donmccurdy i've removed your code that i used in the post and made it generic. Please reopen this issue as i feel that it's valid, for one of the current examples. I find it extremely important to understand how such a crucial part of the system (materials) will work in the future. It seems like i could have both be
and then node material has
However, the current state of the world is, if i want nodes, the first code block turns to
|
The crux of the problem is that no documentation has yet been written. Certainly we should fix that. There is no need for an open-ended issue discussing how to use NodeMaterial or a theoretical backward-compatible wrapper, unless it is feedback on code that is already checked in. Sorry to be terse, these are too many tangents and resurrections of previous threads, and it is becoming disruptive to the aspects of NodeMaterial that require more focused discussion. |
The checked in code can be seen here: The feedback is:
|
Another topic extracted from #7522 and #14252
When i look at the example here:
https://github.com/mrdoob/three.js/blob/dev/examples/webgl_materials_nodes.html#L361-L367
I'm experiencing cognitive overload when i read this code. For every material prop
.foo
there seems to be a corresponding.node.foo
node.This means that every property
.foo
that i have onMaterial
now, will no longer beTexture,Color,Vector2,Float
etc. but all will beNode
.Every
.foo
property will thus have to be accessed through.foo.value
which is very similar toShaderMaterial.uniforms
.What kind of an interface can i expect with
NodeMaterial
moving to/src
?The text was updated successfully, but these errors were encountered: