Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why circleGeometry has not an height parameter so it could be turn into a Cone easily #12014

Closed
cyth319 opened this issue Aug 22, 2017 · 3 comments
Labels

Comments

@cyth319
Copy link

cyth319 commented Aug 22, 2017

if circleGeometry has an height parameter it would be a coneGeometry automaticly. As far as i understand you already doing it with cylynderGeometry wihle making its top circle's radius 0. but if we build things up from the bottom it would be most beautiful way indeed.

-> give circle a height parameter (if height is 0 its a circle)
-> if height is not 0 its a cone
-> create cylinder two circle and planes between them

Is there a specific reason why you did not it this way?

@WestLangley
Copy link
Collaborator

WestLangley commented Aug 22, 2017

ConeGeometry has the height parameter.

I would not merge cones and circle geometries because they have very different UV patterns mappings.

@cyth319
Copy link
Author

cyth319 commented Aug 22, 2017

@WestLangley what UV pattern means?

@WestLangley
Copy link
Collaborator

Sorry. I meant to say UV mappings.

@Mugen87 Mugen87 closed this as completed Aug 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants