Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish next release #349

Open
yonas opened this issue Dec 7, 2022 · 13 comments
Open

Publish next release #349

yonas opened this issue Dec 7, 2022 · 13 comments

Comments

@yonas
Copy link

yonas commented Dec 7, 2022

It would great to get the latest commits in a new release.

@mrash
Copy link
Owner

mrash commented Dec 7, 2022 via email

@bam80
Copy link

bam80 commented Jun 6, 2023

Yes indeed. I will work on this over the next couple of days.

So it didn't happen back then? As the issue is still open.

@e40
Copy link
Contributor

e40 commented Nov 18, 2023

Just a bump for this. The Homebrew version depends on openssl@1.1, which is now EOL.

Warning: Some installed formulae are deprecated or disabled.
You should find replacements for the following formulae:
  fwknop
  openssl@1.1

Thanks for the work you do. It is very much appreciated. For the life of me, I can't figure out why more people don't use it.

@e40
Copy link
Contributor

e40 commented Dec 11, 2023

https://formulae.brew.sh/formula/fwknop#default

It says it's disabled and my users are having having to install from source.

Any chance we can get an update so the Homebrew formula can be reenabled?

@e40
Copy link
Contributor

e40 commented Dec 13, 2023

@mrash
If there is something I can do to help, I will be happy to do so.

As I said above, the current fwknop is dependent on OpenSSL 1.1, which is now EOL.

@bam80
Copy link

bam80 commented Dec 13, 2023

As it's silence from the author @mrash again, despite an assurance he is willing to continue the work - maybe it's time to take it in our hands and supply PRs, make forks etc.?

It seems like we are on our own here.

@yonas
Copy link
Author

yonas commented Dec 14, 2023

@bam80

I created a fork here: https://github.com/firewall-knock-operator/fwknop/releases/tag/2.6.11

Everyone is invited to submit PRs and automated tests.

Thanks!

@bam80
Copy link

bam80 commented Dec 14, 2023

@yonas are you willing to maintain it and do actual work?

I recall there are already some great patches flying around (as IPv6 support), which were never adopted here for unknown reason.
Maybe start with integrating that?

@yonas
Copy link
Author

yonas commented Dec 14, 2023

@bam80 Oh hell no. I don't know anything about this security sensitive code. I've invited you and @e40 to do the actual hard labour.

@mrash
Copy link
Owner

mrash commented Dec 14, 2023

Hi all. The issue with OpenSSL 1.1 mentioned above - fwknop does not depend on the OpenSSL project, and it is not listed as a dependency in the referenced link (https://formulae.brew.sh/formula/fwknop#default). OpenSSL supports a ton of functionality that fwknop does not need. Maybe gpgme depends on OpenSSL (I haven't checked), but fwknop itself does not. For example, for fwknop, the Rijndael (AES) implementation is this one: https://metacpan.org/dist/Crypt-Rijndael/source/_rijndael.c. An explicit goal of the fwknop project is to minimize dependencies as articulated here: https://cipherdyne.org/fwknop/docs/fwknop-tutorial.html#minimize-dependencies

@bam80
Copy link

bam80 commented Dec 14, 2023

Yes indeed. I will work on this over the next couple of days. I want to put
fwknop through its paces on various updated platforms.

Hi @mrash . After a year, it were just a few commits merged.
What is your vision how we should progress?
In current state, the project seems abandoned.

Should we rely on you for further work, or it's just false hopes?

@e40
Copy link
Contributor

e40 commented Jan 10, 2024

@mrash

Hi all. The issue with OpenSSL 1.1 mentioned above - fwknop does not depend on the OpenSSL project, and it is not listed as a dependency in the referenced link (https://formulae.brew.sh/formula/fwknop#default). OpenSSL supports a ton of functionality that fwknop does not need. Maybe gpgme depends on OpenSSL (I haven't checked), but fwknop itself does not. For example, for fwknop, the Rijndael (AES) implementation is this one: https://metacpan.org/dist/Crypt-Rijndael/source/_rijndael.c. An explicit goal of the fwknop project is to minimize dependencies as articulated here: https://cipherdyne.org/fwknop/docs/fwknop-tutorial.html#minimize-dependencies

Doesn't the best option seen to be to just rebuild with the latest everything? I realize I can build from source and break the OpenSSL 1.1 dependency. I just don't know how I could get a fixed version into Homebrew that doesn't depend on it. It seems since you own the project, you would need to be the one to do this.

If you want to point me to resources, so I can help out, please do. I just don't know how to update what's in Homebrew. Thanks.

@e40
Copy link
Contributor

e40 commented Jan 10, 2024

I tried building from source on macOS 14.2.1 with up-to-date Homebrew packages:

checking for GPGME - version >= 0.4.2... yes
checking for gpg... /opt/homebrew/bin/gpg
checking for wget... /opt/homebrew/bin/wget
./configure: line 18861: syntax error near unexpected token `;;'
./configure: line 18861: `   ;;' 

This is after running autogen.sh and running autoupdate when needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants