Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code by replacing silent errors #90

Open
mrWh1te opened this issue Jan 22, 2021 · 1 comment
Open

Improve code by replacing silent errors #90

mrWh1te opened this issue Jan 22, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@mrWh1te
Copy link
Owner

mrWh1te commented Jan 22, 2021

Multiple instances in the code capture errors and provides safe fallbacks. This will increase debug work as the source of errors is obscure. This issue is in favor of changing the code to fail loudly. This will help devs find the source of the bug quicker

databaseName ? databaseName : injectDatabaseName ? injectDatabaseName : 'missing-db-name',

Determine a standard practice then document it:

  • Either use logError() or logWarning()
@mrWh1te mrWh1te added enhancement New feature or request good first issue Good for newcomers labels Jan 22, 2021
@mrWh1te
Copy link
Owner Author

mrWh1te commented Jan 22, 2021

When it comes to Errors, the only standard set in this library is that you ONLY catch errors by using the errors()() BotAction

TBD:
Beyond that, logging of errors and warnings is to be handled either by the BotAction's themselves or through the errors() BotAction.

@mrWh1te mrWh1te removed the good first issue Good for newcomers label Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant