-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft: v2 core #139
base: master
Are you sure you want to change the base?
Draft: v2 core #139
Conversation
- needs types and interfaces - separate lib to develop v2 of core - piece meal dx
- uses browser(), browserPage() to inject 'browser' then 'page' - uses inline Action to utilize `page` inject (tbd rn params) to go to website working
- Actions for puppeteer - input, local storage, navigation, scrape - Actions for corev2 - errors, loops
- default will use initial page if exists otherwise create a new one, just like the original behavior used in bot examples
- tweaked errors action typing
- auth, start of navigation, start of music player actions
- bot that opens (then closes when done) a browser & page on schedule M-F 630am to play music from Idealism on Soundcloud
- 2 problems - sometimes an Action that requires an Inject that hasnt been injected yet doesnt throw a static type error - when it does throw an error, the error message isnt very helpful, the first part lights the way, the message itself sometimes doesnt help
Codecov Report
@@ Coverage Diff @@
## master #139 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 39 39
Lines 671 671
Branches 164 164
=========================================
Hits 671 671 Continue to review full report at Codecov.
|
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
Description
See #87
Screenshots
While technically not a screenshot, check out the
music-alarm
app for a demo app using the new architecture. Currently, it uses a cron job schedule to open the browser to an artist soundcloud, plays their music for a while then closes until the next scheduled alarm.Related
Checklist
browser()()
auto-close browser after actionserrors()()
in appspuppeteer-reddit
vs packages that build bots but without puppeteerDocumentation
Publishing
Blog
BotAction
->Action
)