Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(v7 beta) Add an option in input editor to add a new input/command (Worked in V6) #640

Open
BillyBob1354 opened this issue Jan 9, 2024 · 1 comment
Assignees

Comments

@BillyBob1354
Copy link

BillyBob1354 commented Jan 9, 2024

Is your feature request related to a problem? Please describe.
V6 had a blank input field at the bottom of the list in the input editor that you could add a new input/command to, it is no longer in V7 beta so you have to edit the input.conf file to add a new input.

Describe the solution you'd like
Add a right click menu or a button in the input editor to add a "new input, new action, etc.".

Describe alternatives you've considered
Re-add the blank field at the bottom of the list.
Do nothing, just edit the input.conf. (v7 does not have that file by default, so clicking "Edit input.conf" does nothing with default settings)

Additional context
image

@d4k0
Copy link

d4k0 commented Feb 3, 2024

I have the same problem. Unfortunately, the instructions are contradictory:

Before version v7 all bindings and the context menu definition were defined in the input.conf file, which mpv.net created in case it didn't exist. This had the disadvantage that mpv.net lost control over all default bindings and context menu defaults. This was unfortunate, v7 introduces a new bindings and context menu design fixing it.

In v7 no input.conf file is created, the default bindings and context menu is defined internally. input.conf only contains what is different from the internally defined defaults, so it works the same as it works in mpv.

For backward compatibility the old input.conf context menu format with the menu definition using #menu: is still supported. The new design also allows for a menu customization, in a sub section called Custom. In input.conf it can be defined like so:

Ctrl+a show-text Test #custom-menu: Test > Test

Users that have their bindings and context menu customized before v7 can easily migrate to the new design by deleting bindings they don't use and remember the shortcut and remove #menu: everywhere, it's important to remove #menu: everywhere in order to enable the new mode/design.

Source: https://github.com/mpvnet-player/mpv.net/blob/main/docs/manual.md#input-and-context-menu

On the one hand, it is claimed that no input.conf is created. On the other hand, it is said that this file only contains entries that differ from the internal default settings.

I have now played around a bit, took the old input.conf and only left my entries there. That works. However, there currently seems to be no option in the program to add your own entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants