Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call out specific cryptography choices made #34

Open
MartinPetkov opened this issue Feb 6, 2023 · 0 comments
Open

Call out specific cryptography choices made #34

MartinPetkov opened this issue Feb 6, 2023 · 0 comments

Comments

@MartinPetkov
Copy link

While the core of Portable Secret uses the W3C Web Cryptography APIs (which is great!), the specific choices of cryptography parameters matter and can drastically affect the security of the implementation. These should be called out in the README.md so they can be more easily assessed by those with enough knowledge of cryptography primitives.

Specifically, this is what I found in the source:

  • The secret is encrypted using a derived key, not directly with the password.
  • This key is 32 bytes long and derived from the password using PBKDF2 with 1,000,000 (1 million) iterations.
  • A 16 byte salt is used.
  • The derived key is configured to be non-extractable.
  • The derived key is used for AES-GCM.
  • AES and the IV use a block size of 16 bytes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant