Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arch-independent config header #36

Open
Enchufa2 opened this issue Apr 4, 2023 · 1 comment
Open

Arch-independent config header #36

Enchufa2 opened this issue Apr 4, 2023 · 1 comment

Comments

@Enchufa2
Copy link

Enchufa2 commented Apr 4, 2023

I was taking a look at the automated checks for the latest update, and there's this warning:

Undeclared file conflicts:
flexiblas-devel-3.3.1-1.fc39.i686 provides /usr/include/flexiblas/flexiblas_config.h which is also provided by flexiblas-devel-3.3.1-1.fc39.x86_64
flexiblas-devel-3.3.1-1.fc39.x86_64 provides /usr/include/flexiblas/flexiblas_config.h which is also provided by flexiblas-devel-3.3.1-1.fc39.i686

The issue is that both the i686 and x86_64 devel packages provide the same config header, but with different contents. This creates a conflict in multilib settings. I implemented this fix that basically renames the file as flexiblas_config-%{_arch}.h and replaces the original with an arch-independent stub (see this for further info).

Please, let me know if you see any issue with this approach. If this can be solved upstream, that would be nice. Otherwise, I'll leave this fix in place if you find no shortcomings.

@grisuthedragon
Copy link
Member

The reason for the changing flexiblas_config.h file is, that it contains the library search path, which are different between i686 and x86_64. Namely, these defines are affected by this:

#define FLEXIBLAS_DEFAULT_LIB_PATH "/usr/lib64/flexiblas/"
#define CMAKE_INSTALL_FULL_LIBDIR "/usr/lib64"

For now, I think your fix is ok, but for future use, e.g. in a multi-arch Debian/Ubuntu system, I have to build a similar solution into FlexiBLAS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants