Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Page break inside: 'avoid' can cause table background to be copied to previous page #570

Open
RyanDwyer opened this issue Nov 28, 2017 · 1 comment · May be fixed by #604
Open

Page break inside: 'avoid' can cause table background to be copied to previous page #570

RyanDwyer opened this issue Nov 28, 2017 · 1 comment · May be fixed by #604
Labels
bug/fix rendering tables

Comments

@RyanDwyer
Copy link

I found this bug / would like to have this new functionality

When you have markup like this:

<table>...</table>

<div style="page-break-inside:avoid">
    <table bgcolor="red">...</table>
</div>

...and mPDF decides to move the page break div to a new page, the previous page will contain the background color of the table which was moved to the new page.

The first table is required for this bug to present itself.

This is mPDF and PHP version and environment (fpm/cli etc) I am using

mPDF 7.0.2
PHP 7.0.25

This is a PHP code snippet I use

<?php
require 'vendor/autoload.php';

$mpdf = new Mpdf\Mpdf;

$before = str_repeat('<p>Before</p>', 20);
$after = str_repeat('<p>After</p>', 10);

$html = <<<HTML
    $before

    <table>
        <tr>
            <td>Normal table cell</td>
        </tr>
    </table>

    <div style="page-break-inside:avoid">
        <table>
            <tr>
                <td bgcolor="red">Red table cell</td>
            </tr>
        </table>

        $after
    </div>
HTML;

$mpdf->writeHtml($html);
$mpdf->output();

Example of incorrect rendering

image
RyanDwyer added a commit to RyanDwyer/mpdf that referenced this issue Jan 9, 2018
@RyanDwyer
Do not render table backgrounds when considering page breaks.
a0f752a 
Fixes mpdf#570.
@RyanDwyer RyanDwyer linked a pull request Jan 9, 2018 that will close this issue
Open
RyanDwyer added a commit to RyanDwyer/mpdf that referenced this issue Mar 10, 2019
@RyanDwyer
Do not render table backgrounds when considering page breaks.
cbdd7b3 
Fixes mpdf#570.
RyanDwyer added a commit to RyanDwyer/mpdf that referenced this issue Mar 10, 2019
@RyanDwyer
Do not render table backgrounds when considering page breaks.
750090c 
Fixes mpdf#570.
@JoseCorralesN
Copy link

Why this solution is not added yet to main branch? it works!

@finwe finwe mentioned this issue Oct 25, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug/fix rendering tables
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Do not render table backgrounds when considering page breaks. RyanDwyer/mpdf
3 participants
@finwe @RyanDwyer @JoseCorralesN