Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

!w works only for US locations #3

Open
Lr5 opened this issue Feb 12, 2013 · 2 comments
Open

!w works only for US locations #3

Lr5 opened this issue Feb 12, 2013 · 2 comments
Assignees

Comments

@Lr5
Copy link

Lr5 commented Feb 12, 2013

The command !w currently seems to work only for US locations. For example, the following commands don't work:

!w Paris, France
!w Espoo, Finland
!w Espoo

@ghost ghost assigned jpearsall Feb 12, 2013
@jpearsall
Copy link
Contributor

This was totally my bad. See lines 47 and 57:

47: my $o_state = $decoded_json->{'location'}->{'state'};
57: if( $o_tz eq '', $o_city eq '', $o_state eq '' ) {

As we can see with Paris, France and Espoo, Finland there is no state populated:

"country_name":"France",
"state":"",
"city":"Paris",

"country_name":"Finland",
"state":"",
"city":"Espoo",

Fix is forthcoming. :)

@jpearsall
Copy link
Contributor

http://pastebin.ca/2313277

Another commit via pastebin 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants