Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove --id flag on web-ext sign #3126

Merged
merged 2 commits into from
May 27, 2024
Merged

feat: remove --id flag on web-ext sign #3126

merged 2 commits into from
May 27, 2024

Conversation

willdurand
Copy link
Member

@willdurand willdurand commented May 7, 2024

Fixes #3124


As per #2458 (comment), we require the add-on ID to be specified in the manifest.

⚠️ This is another breaking change, and since it was confusing, I am going to document a few use cases below.

New MV2 add-on, no ID in the manifest

Add-on ID is generated by AMO, a message is printed to update the manifest.json file:

Generated extension ID: {297f6bbb-7604-41ca-8473-0b685e4ae3ff}.
You must add the following to your manifest:
"browser_specific_settings": {"gecko": {"id": "{297f6bbb-7604-41ca-8473-0b685e4ae3ff}"}}

Add-on submitted successfully.

Existing MV2 add-on, no ID in the manifest

An error is thrown by web-ext:

UsageError: Cannot use previously auto-generated extension ID {297f6bbb-7604-41ca-8473-0b685e4ae3ff} - This extension ID must be specified in the manifest.json file.

New MV2 add-on, ID in the manifest

Add-on submitted successfully.

Existing MV2 add-on, ID in the manifest

Add-on submitted successfully.

New MV3 add-on, no ID in the manifest

An error is thrown by web-ext:

UsageError: An extension ID must be specified in the manifest.json file.

New MV3 add-on, ID in the manifest

Add-on submitted successfully.

src/cmd/sign.js Show resolved Hide resolved
src/cmd/sign.js Outdated Show resolved Hide resolved
Co-authored-by: Rob Wu <rob@robwu.nl>
@willdurand willdurand removed the request for review from rpl May 27, 2024 13:58
@willdurand willdurand changed the title Remove --id flag on web-ext sign feat: Remove --id flag on web-ext sign May 27, 2024
@willdurand willdurand changed the title feat: Remove --id flag on web-ext sign feat: remove --id flag on web-ext sign May 27, 2024
@willdurand willdurand merged commit 0539cce into master May 27, 2024
3 of 4 checks passed
@willdurand willdurand deleted the rm-id branch May 27, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

--id flag seems to be unused in HEAD (8.0.0 pre-release)
2 participants