You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
During the drafting process for the web-ext 8.0.0 release's documentation update, @rebloornoted that that the "--id [seems to have] no purpose in version 8." Upon reviewing the source and running through a couple test cases, I did not see a way to effectively use the --id flag in the current master branch.
I suggest that we remove the --id flag before we formally release version 8.0.0.
Case 1: Using--id when submitting a new add-on without an id in manifest.json
$ web-ext sign --id "2024-05-06-test1@webext.test"
Building web extension from /Users/current-user/2024-05-06-test1/src
UsageError: Cannot set custom ID 2024-05-06-test1@webext.test - The add-on ID must be specified in the manifest.json file.
Case 2: Using--id when signing an add-on with an id in manifest.json
$ web-ext sign --id "2024-05-06-test2@webext.test"
Building web extension from /Users/current-user/2024-05-06-test2/src
UsageError: Cannot set custom ID 2024-05-06-test2@webext.test because manifest.json already defines ID ${manifestId}
The text was updated successfully, but these errors were encountered:
@willdurand, it looks like you may have been the last person to touch some related code in #2737. Am I missing anything that would necessitate keeping the --id flag?
Keep --id flag (and automatic id detection previously saved to a file), and repurpose this to improve the developer experience when the ID is missing from manifest.json. In this case, show a suggestion on how the manifest.json file should be corrected.
During the drafting process for the web-ext 8.0.0 release's documentation update, @rebloor noted that that the "
--id
[seems to have] no purpose in version 8." Upon reviewing the source and running through a couple test cases, I did not see a way to effectively use the--id
flag in the current master branch.I suggest that we remove the
--id
flag before we formally release version 8.0.0.Case 1: Using
--id
when submitting a new add-on without anid
in manifest.json2024-05-06-test1.zip
Case 2: Using
--id
when signing an add-on with anid
in manifest.json2024-05-06-test2.zip
The text was updated successfully, but these errors were encountered: