Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nested config settings can overwrite each other #3104

Closed
dotproto opened this issue Apr 15, 2024 · 4 comments · Fixed by #3136
Closed

Nested config settings can overwrite each other #3104

dotproto opened this issue Apr 15, 2024 · 4 comments · Fixed by #3136
Assignees
Milestone

Comments

@dotproto
Copy link
Contributor

Is this a feature request or a bug?

Bug

What is the current behavior?

  1. Add the following configuration to a WebExtension project.
    module.exports = {
      "lint": {
        "firefoxPreview": ['mv3'],
      },
      "run": {
        "firefoxPreview": ['']
      }
    };
  2. CD into that project's directory and run web-ext lint --firefox-preview.
  3. Observe that the following message is logged to the console. This is expected.
    Manifest Version 3 is now officially supported and "--firefox-preview=mv3" is no longer needed. In addition, the "mv3" value will be removed in the future.
    
  4. Run web-ext lint.
  5. Observe that the message from step 3 is not logged to the console.

What is the expected or desired behavior?

Command-specific settings declared in a configuration file should not interfere with each other.

Version information (for bug reports)

  • Firefox version: 126.0a1
  • Your OS and version: macOS 14.4.1
  • Paste the output of these commands:
node --version && npm --version && web-ext --version
v21.6.2
10.2.4
master-e2bee027dee8e1a56dd49fd567edddc7ad75220c

This is a manually built version of web-ext that is very close to 8.0.0.

@Rob--W
Copy link
Member

Rob--W commented May 23, 2024

This is a bug specific to the --firefox-preview implementation. When the flag is empty, we default to mv3 being specified.

We're going to resolve this issue by dropping the --firefox-preview flag. Since this is a breaking change, we'd like to make this part of the 8.0.0 release.

@willdurand
Copy link
Member

We removed --firefox-preview entirely.

@ioanarusiczki
Copy link

ioanarusiczki commented May 24, 2024

Updated to master-f814a6195ad8a40d3bca1fc8105473a94e79bdca - V8

With web-ext lint --firefox-preview the message is unknown argument

unknown arguments

@ioanarusiczki
Copy link

Ah to add , with web-ext lint ran for an extension , it looks good, should be as expected.

as expexted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants