feat: Add --chromium-pref flag
#2912
Open
+177
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aklinker1
commented
Oct 15, 2023
| @@ -66,6 +66,9 @@ describe('util/extension-runners/chromium', async () => { | |||
| '--password-store=basic', | |||
| '--use-mock-keychain', | |||
| '--force-fieldtrials=*BackgroundTracing/default/', | |||
| '--disable-hang-monitor', | |||
| '--disable-prompt-on-repost', | |||
| '--disable-domain-reliability', | |||
There was a problem hiding this comment.
These changes were required after upgrading chrome-launcher, similar to #2825 (comment)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2912 +/- ##
===========================================
+ Coverage 0 99.31% +99.31%
===========================================
Files 0 32 +32
Lines 0 1759 +1759
===========================================
+ Hits 0 1747 +1747
- Misses 0 12 +12 ☔ View full report in Codecov by Sentry. |
aklinker1
force-pushed
the
enable-developer-mode
branch
from
f6cda7b
to
6442c6c
Compare
|
Rebased and fixed merge conflicts |
aklinker1
force-pushed
the
enable-developer-mode
branch
from
4d10f82
to
c8dea96
Compare
|
Rebased and fixed conflicts |
VersoriumX
approved these changes
Dec 23, 2023
|
No conflicts present with Branch |
VersoriumX
approved these changes
Dec 23, 2023
VersoriumX
approved these changes
Dec 23, 2023
This was referenced Jan 29, 2024
VersoriumX
approved these changes
Apr 23, 2024
|
@aklinker1 why not merge this pr? I still encounter the content script source map issues |
|
Only maintainers can merge PRs, and this hasn't been approved by one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This closes #2899.
Add a new parameter,
--chromium-pref, which lets users configure some profile settings when running theweb-ext runcommand. For default preferences, I setextensions.ui.developer_mode=trueso you don't have to toggle the developer mode switch every time you run an extension on chromium.web-ext/src/extension-runners/chromium.js
Lines 30 to 32 in 9d0512a
I also had to upgrade
chromium-launcherto v1.1.0 (see GoogleChrome/chrome-launcher#323), so this replaces #2825 and #2901.web-ext/src/extension-runners/chromium.js
Lines 210 to 219 in 9d0512a
Manual Testing
Here's the commands I ran to do manual testing: