Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dupe-metric hack #697

Open
badboy opened this issue Feb 20, 2024 · 1 comment · May be fixed by #725
Open

Remove dupe-metric hack #697

badboy opened this issue Feb 20, 2024 · 1 comment · May be fixed by #725

Comments

@badboy
Copy link
Member

badboy commented Feb 20, 2024

I added a hack to get firefox-desktop to work properly again:

probe-scraper/probe_scraper/glean_checks.py

Lines 19 to 25 in 5717fce

# Ugly hack to skip certain metrics which we know aren't duplicated,
# but show up duplicated due to them being moved from one
# to the other application/library.
SKIP_METRICS = {
"gecko.version": ["gecko", "pine", "firefox-desktop"],
"gecko.build_id": ["gecko", "pine", "firefox-desktop"],
}

We should find a way that this is not necessary.
It shouldn't. The metric is moved from the app to the library.
@BenWu
Copy link
Contributor

BenWu commented Mar 14, 2024

This looks like it could be a similar issue that caused #711 so I'll append to this one. In that case, the metrics file was removed from mozillavpn_backend_cirrus and nimbus-cirrus was added as a dependency so in that case removing the metrics worked

badboy added a commit that referenced this issue Apr 8, 2024
@badboy
Remove skip metric hacks
6fff14a 
Fixes #697
badboy added a commit that referenced this issue Apr 8, 2024
@badboy
Remove skip metric hacks
d51d879 
Fixes #697
@badboy badboy linked a pull request Apr 8, 2024 that will close this issue
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove skip metric hacks, remove engine-gecko mozilla/probe-scraper
2 participants
@badboy @BenWu