New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove skip metric hacks, remove engine-gecko #725

Draft

badboy wants to merge 2 commits into main from cleanup-hacks

Member

badboy commented Apr 8, 2024

Fixes #697

I think we can do this now?
A dry-run locally succeeds.

python3 -m probe_scraper.runner --dry-run --cache-dir tmp/cache --out-dir tmp/out --glean --glean-repo firefox-klar-android --glean-repo service-nimbus --glean-repo nimbus --glean-limit-date 2024-04-01 --update --output-bucket=gs://probe-scraper-prod-artifacts/ --glean-repo firefox-desktop --glean-repo gecko --glean-repo engine-gecko --glean-repo firefox-android-release

might want some more testing before we actually land this.

badboy added 2 commits

April 8, 2024 17:16


          Remove skip metric hacks

d51d879

Fixes #697


          Remove engine-gecko now that it is empty

01d20cb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

chutten Awaiting requested review from chutten chutten will be requested when the pull request is marked ready for review chutten is a code owner

akkomar Awaiting requested review from akkomar akkomar will be requested when the pull request is marked ready for review akkomar is a code owner

whd Awaiting requested review from whd whd will be requested when the pull request is marked ready for review whd is a code owner

mikaeld Awaiting requested review from mikaeld mikaeld will be requested when the pull request is marked ready for review mikaeld is a code owner

Dexterp37 Awaiting requested review from Dexterp37 Dexterp37 will be requested when the pull request is marked ready for review Dexterp37 is a code owner

travis79 Awaiting requested review from travis79 travis79 will be requested when the pull request is marked ready for review travis79 is a code owner

At least 1 approving review is required to merge this pull request.