Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LLM translations are not correctly attributed #3204

Open
flodolo opened this issue May 8, 2024 · 2 comments · Fixed by #3230 · May be fixed by #3241
Open

LLM translations are not correctly attributed #3204

flodolo opened this issue May 8, 2024 · 2 comments · Fixed by #3230 · May be fixed by #3241
Assignees
Labels
bug LLM P2 We want to ship it soon, possibly in the current quarter

Comments

@flodolo
Copy link
Collaborator

flodolo commented May 8, 2024

Click the AI button and select rephrase, then click to copy the text and submit the translation.

The UX action log is correctly recorded (first LLM dropdown select, then LLM dropdown copied).

The translation is incorrectly attributed to Google Translate in the UI, and this code doesn't return any match

from pontoon.base.models import Translation

# List Translation copied from the LLM suggestions
Translation.objects.filter(machinery_sources__contains=['gpt-transform']).values("locale__code", "date")

>>> <TranslationQuerySet []>
@mathjazz
Copy link
Collaborator

Fixed in #3230.

@eemeli
Copy link
Member

eemeli commented May 15, 2024

This isn't completely fixed yet, as the attribution is still wrong when the keyboard shortcut is used:

const { translation, sources } =
nextIdx < len
? machineryTranslations[nextIdx]
: concordanceSearchResults[nextIdx - len];
setEditorFromHelpers(translation, sources, true);

@eemeli eemeli reopened this May 15, 2024
@flodolo flodolo added the LLM label May 17, 2024
@ayanaar ayanaar linked a pull request May 30, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug LLM P2 We want to ship it soon, possibly in the current quarter
Projects
Status: Done
4 participants