Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward compatibility broken from 2.0.402 -> 2.0.419. PDFJS is not defined #9525

Closed
chirag64 opened this issue Mar 3, 2018 · 3 comments
Closed

Comments

@chirag64
Copy link

chirag64 commented Mar 3, 2018

Attach (recommended) or Link to PDF file here:

Configuration:

  • Web browser and its version: N/A
  • Operating system and its version: N/A
  • PDF.js version: 2.0.419
  • Is a browser extension: No

Steps to reproduce the problem:

  1. Try running the code mentioned in an older version of the example docs:
    // The workerSrc property shall be specified.
    PDFJS.workerSrc = '//mozilla.github.io/pdf.js/build/pdf.worker.js';

What is the expected behavior? (add screenshot)
PDF should load with the new version of the library.

What went wrong? (add screenshot)
PDF does not load. Instead, we get a console error that says PDFJS is not defined. Backward compatibility is broken on a minor version upgrade.

Link to a viewer (if hosted on a site other than mozilla.github.io/pdf.js or as Firefox/Chrome extension):

@timothyjensen
Copy link

Thanks for reporting this. I am experiencing the same console error as explained above. When I load version 2.0.402 instead the console error disappears.

@amrbedair
Copy link

same here!

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Mar 4, 2018

[...] Backward compatibility is broken on a minor version upgrade.

That's not really accurate here, since there was a major version increase previously (from 1.x.y to 2.x.y), which should suggest that backwards incompatible changes were made.
Please refer to e.g. #9385 (comment) and #9385 (comment) for additional details.

The first official release from the 2.0 branch will happen any day now, and is tracked in issue #9521 and https://github.com/mozilla/pdf.js/projects/5, and will contain a number of backwards incompatible changes.

Closing as answered/invalid.

@chirag64 chirag64 changed the title Backward compatibility broken from 2.0.402 -> 2.0.419 Backward compatibility broken from 2.0.402 -> 2.0.419. PDFJS is not defined Mar 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants