Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Highlight showing over text in IE, but works in Chrome/Firefox #5264

Closed
msladev opened this issue Sep 4, 2014 · 15 comments
Closed

Highlight showing over text in IE, but works in Chrome/Firefox #5264

msladev opened this issue Sep 4, 2014 · 15 comments
Labels

Comments

@msladev
Copy link

msladev commented Sep 4, 2014

There is a text that was highlighted but in IE the highlight is showing over the text and hiding the original text. However, in Chrome and Firefox the highlight works as expected. Screenshots are shown below.

In IE:
hightlight

In Chrome:
highlight chrome

Thanks,
MSLA-IT

@yurydelendik
Copy link
Contributor

Could you provide link to the PDF document?

@msladev
Copy link
Author

msladev commented Sep 4, 2014

@yurydelendik
Copy link
Contributor

Duplicate of #3900

@yurydelendik
Copy link
Contributor

IE does not implement blending modes. We need to report that to https://connect.microsoft.com

@msladev
Copy link
Author

msladev commented Sep 4, 2014

We tried the suggestion in #3900 but it still doesn't work. Should we include something in the compatibility.js as well?

@yurydelendik
Copy link
Contributor

Not sure, as a prototype code snippet shall work in IE.

@msladev
Copy link
Author

msladev commented Sep 5, 2014

We got it working.

But we changed a different line of code.

highlight fix

Thanks,
MSLA-IT

@yurydelendik
Copy link
Contributor

Here is voting for implementing this feature in IE:

https://status.modern.ie/compositingandblendingincanvas2d?term=globalCompositeOperation

@tbasse
Copy link

tbasse commented Apr 25, 2015

@msladev, your solution worked perfectly for us until we stumbled upon some PDFs which rendered other image and shape elements with a 50% transparency due to this change.

Example PDF: https://dl.dropboxusercontent.com/u/1652601/ht-1-handbook.pdf

We then moved the workaround to CanvasGraphics_beginAnnotation() and only apply it for IE so it only affects the text highlight and only when it needs to.

screen shot 2015-04-25 at 10 42 43 am

@lochstar
Copy link

Thanks @tbasse, works great.

@ArnoldFabasoft
Copy link

We had the same issue in our integration of pdf.js. We implemented the workaround of tbasse for internet explorer. Thanks @tbasse
Will this fix or an other implementation find a way into pdf.js? I want to modify the original code as less as possible.
Thx Stefan

@jeremypress
Copy link

@yurydelendik, would you be open to a contribution that implements this workaround? I highly doubt that Microsoft will be addressing this on their end.

@timvandermeij
Copy link
Contributor

timvandermeij commented Jan 24, 2018

This workaround is not acceptable for in the core because we don't want browser-specific hacks in there, but it may be accepted if it can be feature-detected and placed in https://github.com/mozilla/pdf.js/blob/master/src/shared/compatibility.js.

@jeremypress
Copy link

Makes sense, thanks @timvandermeij!

@timvandermeij
Copy link
Contributor

Closing IE11/Edge (non-Chromium-based) issues in response to #11211. Please note that, as outlined in https://github.com/mozilla/pdf.js/wiki/Frequently-Asked-Questions#faq-support, only bugs which completely prevent the library and/or the default viewer from running will be accepted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

7 participants