Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zoom level detail is not hidden when PDF.js is in small iframe #3140

Closed
aleksejrs opened this issue Apr 22, 2013 · 7 comments
Closed

Zoom level detail is not hidden when PDF.js is in small iframe #3140

aleksejrs opened this issue Apr 22, 2013 · 7 comments
Labels

Comments

@aleksejrs
Copy link

Zoom level detail ("Automatic Zoom") is not hidden when PDF.js is too small in a frame (is hidden in the Firefox PDF Viewer) → toolbar elements do not fit well.

Steps to reproduce:

  1. Set the minimum font size in Firefox to 16.
  2. Open a page with PDF.js in a 640x480 frame (iframe width=640px height=480px)

Actual results:

  • "Automatic Zoom" does not fit, "−" touches (or crosses) the total number of pages.

Expected results:

  • More should fit.
  • In Firefox's internal PDF Viewer, "Automatic Zoom" would be hidden in this case.
@Snuffleupagus
Copy link
Collaborator

This should be fixed once #2792 lands.

@timvandermeij
Copy link
Contributor

@Snuffleupagus Is this fixed now?

@Snuffleupagus
Copy link
Collaborator

I just checked, and it's almost fixed now. I think a slight CSS tweak might still be in order, I'll look into this.

@Snuffleupagus
Copy link
Collaborator

I created the following testcase (I hope this is right, since the OP didn't provide one): http://jsbin.com/EsiwuXo/2.
It looks sort of OK for documents with two-digit page numbers, but the issue is still there in files with three-digit page numbers.

@timvandermeij
Copy link
Contributor

@Snuffleupagus Just a suggestion, but since there is not enough space, wouldn't removing the 'Page' text help? I see Acrobat doesn't have that text either (as it's kind of obvious) and that text can be longer in other languages (for example in Dutch it's 'Pagina').

Edit: or we can move the bookmark button to the secondary toolbar if the size is too small.

@Snuffleupagus
Copy link
Collaborator

wouldn't removing the 'Page' text help?

That might work, and it sounds like the best approach. Note that it's already removed at a smaller window width, but it might be OK to the increase that value somewhat.

Edit: or we can move the bookmark button to the secondary toolbar if the size is too small.

The issue is with the zoom out/in buttons, so that wouldn't help unfortunately.

@Snuffleupagus
Copy link
Collaborator

Now that PR #3671 has been merged, I think this looks good enough (in most languages) to no longer be an issue.

Closing as resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants