-
Notifications
You must be signed in to change notification settings - Fork 9.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Zoom level detail is not hidden when PDF.js is in small iframe #3140
Comments
This should be fixed once #2792 lands. |
@Snuffleupagus Is this fixed now? |
I just checked, and it's almost fixed now. I think a slight CSS tweak might still be in order, I'll look into this. |
I created the following testcase (I hope this is right, since the OP didn't provide one): http://jsbin.com/EsiwuXo/2. |
@Snuffleupagus Just a suggestion, but since there is not enough space, wouldn't removing the 'Page' text help? I see Acrobat doesn't have that text either (as it's kind of obvious) and that text can be longer in other languages (for example in Dutch it's 'Pagina'). Edit: or we can move the bookmark button to the secondary toolbar if the size is too small. |
That might work, and it sounds like the best approach. Note that it's already removed at a smaller window width, but it might be OK to the increase that value somewhat.
The issue is with the zoom out/in buttons, so that wouldn't help unfortunately. |
Now that PR #3671 has been merged, I think this looks good enough (in most languages) to no longer be an issue. Closing as resolved. |
Zoom level detail ("Automatic Zoom") is not hidden when PDF.js is too small in a frame (is hidden in the Firefox PDF Viewer) → toolbar elements do not fit well.
Steps to reproduce:
Actual results:
Expected results:
The text was updated successfully, but these errors were encountered: