Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gulp to version 5.0.0 #17922

Open
timvandermeij opened this issue Apr 11, 2024 · 1 comment
Open

Upgrade gulp to version 5.0.0 #17922

timvandermeij opened this issue Apr 11, 2024 · 1 comment

Comments

@timvandermeij
Copy link
Contributor

timvandermeij commented Apr 11, 2024

We should upgrade to Gulp 5 now that it's officially released. The changelog, including the breaking changes that mostly don't seem to affect us, can be found at https://github.com/gulpjs/gulp/releases/tag/v5.0.0.

I have already quickly tried the upgrade locally to see if it would be easy or not, and found that the main blocker appears to be the merge-stream package. It doesn't seem to work anymore with Gulp 5, causing tracebacks for most tasks (because of most of them directly or indirectly rely on merge calls).

The last commit for merge-stream, see https://github.com/grncdr/merge-stream, was 5 years ago, so this probably isn't very surprising. However, I played around with removing the merge calls altogether and didn't immediately find something that was obviously broken, so I'm mainly wondering what the use case of it is or was at the time of introduction (maybe it's obsolete nowadays, or something breaks when removing it that I just haven't noticed yet...). Sadly I haven't been able to find out more from e.g. Git commit messages.

We should investigate if merge-stream can be fixed, replaced or removed. Once that is addressed Gulp 5 should work, but note that we still need to carefully test all commands.

@Snuffleupagus
Copy link
Collaborator

Could https://github.com/sindresorhus/merge-streams be a possible replacement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants