A single page pdf is taking 4 min to render #17779
Labels
Comments
|
Is the underlying issue here perhaps (partially) related to the fact that SMask handling is inefficient, given the use of |
Yep, it's on my long todo list. |
Closed
calixteman
added a commit
to calixteman/pdf.js
that referenced
this issue
Apr 30, 2024
and implement then in using some SVG filters and composition. Composing in using destination-in in order to multiply RGB components by the alpha from the mask isn't perfect: it'd be a way better to natively have alpha masks support, it induces some small rounding errors and consequently computed RGB are approximatively correct. In term of performance, it's a real improvement, for example, the pdf in issue mozilla#17779 is now rendered in few seconds. There are still some room for improvement, but overall it should be a way better.
calixteman
added a commit
to calixteman/pdf.js
that referenced
this issue
Apr 30, 2024
and implement then in using some SVG filters and composition. Composing in using destination-in in order to multiply RGB components by the alpha from the mask isn't perfect: it'd be a way better to natively have alpha masks support, it induces some small rounding errors and consequently computed RGB are approximatively correct. In term of performance, it's a real improvement, for example, the pdf in issue mozilla#17779 is now rendered in few seconds. There are still some room for improvement, but overall it should be a way better.
calixteman
added a commit
to calixteman/pdf.js
that referenced
this issue
May 1, 2024
…(bug 1874013) and implement then in using some SVG filters and composition. Composing in using destination-in in order to multiply RGB components by the alpha from the mask isn't perfect: it'd be a way better to natively have alpha masks support, it induces some small rounding errors and consequently computed RGB are approximatively correct. In term of performance, it's a real improvement, for example, the pdf in issue mozilla#17779 is now rendered in few seconds. There are still some room for improvement, but overall it should be a way better.
|
Should we close this now that #18029 was merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Attach (recommended) or Link to PDF file here:
p95.pdf
Configuration:
Steps to reproduce the problem:
It seems that the pdf contains a lot of paths outside the clip box and for each of them we call with a
nullargument:pdf.js/src/display/canvas.js
Line 1788 in 6bb6ce6
which itself calls at some point:
pdf.js/src/display/canvas.js
Line 838 in 6bb6ce6
That said, the overall rendering is incorrect: the lines for the borders and some grayed countries are not rendered at all.
The text was updated successfully, but these errors were encountered: