Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two icons for DropDownButtons #13979

Closed
nedy13 opened this issue Sep 6, 2021 · 3 comments
Closed

Two icons for DropDownButtons #13979

nedy13 opened this issue Sep 6, 2021 · 3 comments

Comments

@nedy13
Copy link

nedy13 commented Sep 6, 2021

I think this issue is related to this change: Implement Photon design for the viewer #11077

Configuration:

  • Web browser and its version: Firefox 91.0.2
  • Operating system and its version: Win10
  • PDF.js version: included in Firefox 91.0.2
  • Is a browser extension: no

Steps to reproduce the problem:

  1. Open Browser's developer console
  2. change width of .dropdownToolbarButton to e.g. 250px in developer console

I think only one icon is the expected one.

image

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Sep 6, 2021

Open Browser's developer console
change width of .dropdownToolbarButton to e.g. 250px in developer console

Can you reproduce this issue in any other way than by manually changing the width using the devtools?
Please keep in mind that what you're describing above is neither an intended nor supported use-case.

@nedy13
Copy link
Author

nedy13 commented Sep 6, 2021

No, there is no other way to reproduce.

I only observed this, because I upgraded the PDFjs version in our own 3rd party integration and we created some different theme. I only wondered that there is a second icon. I know this is a minor / low issue, but I only want to log this as bug, because this is not expected / wanted.

@Snuffleupagus
Copy link
Collaborator

No, there is no other way to reproduce.

In that case, this issue is basically INVALID.

I only observed this, because I upgraded the PDFjs version in our own 3rd party integration and we created some different theme.

Ah, so your question is actually about customizing the default viewer. (Please note that that's the kind of information that's always helpful to state clearly upfront :-)

If you want to customize the width of the zoom-dropdown, you'll need to edit the following values:

I only wondered that there is a second icon.

Because we want to re-use the native select element for overall simplicity, but provide the same icon regardless of browser and OS, hence we set the widths such that the browser icon becomes hidden (which your manual changes thus broke).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants