Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move 2.6.347 to release and add new release #12851

Closed
brendandahl opened this issue Jan 11, 2021 · 10 comments
Closed

Move 2.6.347 to release and add new release #12851

brendandahl opened this issue Jan 11, 2021 · 10 comments
Assignees
Labels

Comments

@brendandahl
Copy link
Contributor

It's been awhile. @timvandermeij do you have time to do a new one?

@Snuffleupagus
Copy link
Collaborator

Can we try and get PR #12726 landed first, such that it's included in the next release?

@timvandermeij
Copy link
Contributor

Yes, we can do this, but it would be great to have that PR included if possible. Brendan, do you have time to finish that one?

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Jan 20, 2021

Unless PR #12726 is likely to be updated soon, should we perhaps do the following:

  1. Create a new release ASAP, given how long it's been since the last one.
  2. Once PR [api-minor] Include and use the 14 standard font files. #12726 lands, create a new release very soon afterwards. Given the potential impact of that PR, it might even warrant its "own" release anyway!?

@timvandermeij
Copy link
Contributor

I'd be fine with that. @brendandahl Do you think that PR can be updated soon, or should we proceed with this release?

@brendandahl
Copy link
Contributor Author

I've been looking into it. I'm trying to do some benchmarks, but unfortunately our current setup doesn't really measure the font conversion. I'm going to do some pushes to mozilla's talos to see how perf is there.

@Snuffleupagus
Copy link
Collaborator

Given that PR #12726 looks to be further from landing than I hoped, given the performance regressions, let's just create a new release ASAP :-)

The release notes, for the new release, should probably mention that IE 11 is now unsupported.

@timvandermeij timvandermeij self-assigned this Jan 24, 2021
@timvandermeij
Copy link
Contributor

Yes, I'll get this done today.

@timvandermeij
Copy link
Contributor

timvandermeij commented Jan 24, 2021

The release is done. On NPM the next tag is already updated with version 2.7.570. @brendandahl Because of #12324 the latest tag is not updated again. Could you update it manually to version 2.6.347?

@brendandahl
Copy link
Contributor Author

done

@timvandermeij
Copy link
Contributor

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants