Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't imput any characters involving a modifier since commit ef1030789 #2553

Closed
leodag opened this issue Aug 1, 2023 · 2 comments · Fixed by #2587
Closed

Can't imput any characters involving a modifier since commit ef1030789 #2553

leodag opened this issue Aug 1, 2023 · 2 comments · Fixed by #2587
Assignees
Labels
bug Something is broken! Component: Shortcuts Issues related to keyboard shortcuts Status: Confirmed We've tested it and were able to reproduce

Comments

@leodag
Copy link
Contributor

leodag commented Aug 1, 2023

I was testing another issue I will be opening soon, when I noticed I couldn't imput a ':' at all - in none of the text fields. In fact, nothing that needs a modifier was working, even doing Ctrl+v.

Bisecting from the version I'm actually using day-to-day (8.1.2) I reached the commit ef10307, which changes shortcut handling.

@dannycolin dannycolin added bug Something is broken! Component: Shortcuts Issues related to keyboard shortcuts Status: Confirmed We've tested it and were able to reproduce labels Oct 13, 2023
@dannycolin dannycolin self-assigned this Oct 13, 2023
@dannycolin
Copy link
Collaborator

Good catch. However, this commit isn't in 8.1.2 because it has been merged after it. So it should affect the version on AMO.

@leodag
Copy link
Contributor Author

leodag commented Oct 13, 2023

That's right, it doesn't affect the version on AMO, should have made that clear. I only caught this after pulling the extension while doing the fix for #2556.

@dannycolin dannycolin linked a pull request Oct 17, 2023 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is broken! Component: Shortcuts Issues related to keyboard shortcuts Status: Confirmed We've tested it and were able to reproduce
Projects
None yet
2 participants