Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Icons don't seem to fit in with the new Proton UI #2023

Open
bepvte opened this issue Apr 21, 2021 · 4 comments · May be fixed by #2546
Open

Icons don't seem to fit in with the new Proton UI #2023

bepvte opened this issue Apr 21, 2021 · 4 comments · May be fixed by #2546
Assignees
@dannycolin
Labels
Needs: UX Needs to be reviewed by the UX team 👍 Feature Request Feature requests users would like to see in this addon
Milestone
8.2

Comments

@bepvte
Copy link

bepvte commented Apr 21, 2021

Proton's new icon style is very nice, but it seems that the multi account containers icon does not fit its style yet:
image

If this is a deliberate choice, or you already have plans to update it when proton officially releases on the stable branch of firefox, feel free to close this issue.
@scheinercc
Copy link

It also stands out a bit too much in the address bar (dark mode, macOS, Alpenglow)
image

@lesleyjanenorton
Copy link
Collaborator

A personal nit of mine as well. @groovecoder who can be appealed to here?

@dannycolin dannycolin added the Needs: UX Needs to be reviewed by the UX team label Dec 28, 2022
@dannycolin dannycolin self-assigned this Dec 28, 2022
@dannycolin dannycolin added this to the 8.2 milestone Jan 3, 2023
@dannycolin
Copy link
Collaborator

It also stands out a bit too much in the address bar

This one is going away with Manifest v3

Proton's new icon style is very nice, but it seems that the multi account containers icon does not fit its style yet

image

Looks good?

@dannycolin dannycolin added the 👍 Feature Request Feature requests users would like to see in this addon label Jan 11, 2023
@bepvte
Copy link
Author

bepvte commented Jan 11, 2023

Looks great!

@dannycolin dannycolin linked a pull request Jun 20, 2023 that will close this issue
Update iconography to match Firefox Design System #2546
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dannycolin dannycolin

Labels
Needs: UX Needs to be reviewed by the UX team 👍 Feature Request Feature requests users would like to see in this addon
Projects
None yet
Milestone
8.2
Development

Successfully merging a pull request may close this issue.

Update iconography to match Firefox Design System dannycolin/multi-account-containers
4 participants
@scheinercc @dannycolin @bepvte @lesleyjanenorton